This repository was archived by the owner on Nov 17, 2022. It is now read-only.
Fixed healthcheck#11
Open
tamas-molnar wants to merge 9 commits intomasterfrom
Open
Conversation
Contributor
tamas-molnar
commented
Oct 8, 2018
tamas-molnar
commented
- existing healthcheck chose the check to make based on the state of burrow at kafka-lagcheck startup, which meant that subsequent changes in burrow state (like actually starting) weren't picked up by the kafka-lagcheck healthchecks
- fixed the above issue and refactored healtchecks to be more in line with current conventions
- fixed tests
⚠️ tests now have a data race, still looking into it
added 9 commits
September 10, 2018 12:59
This reverts commit 89cc779.
…2 checks instead of one per consumer group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.