This repository was archived by the owner on Nov 17, 2022. It is now read-only.
Your runbooks.yaml file is probably no longer needed#24
Open
bot-tooling wants to merge 1 commit intomasterfrom
Open
Your runbooks.yaml file is probably no longer needed#24bot-tooling wants to merge 1 commit intomasterfrom
bot-tooling wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Financial-Times/universal-publishing
Recent changes to RUNBOOK.md mean you probably don't need these rules:
updateOnMergeandupdateBranch- if these were just set up to updateon merge to your default branch there is no need for them any more. RUNBOOK.md
does this by default.
disabled: falseandfailOn: 'any'- again this is the default behaviour sois not needed.
systemCodesmap - you probably have## Codedefined within each of yourrunbooks now, or have the code as part of the file name for each runbook, so
defining it in the yaml config is unnecessary duplication. Even if you don't have this,
it's recommended that you switch to defining codes in your runbook files as it is
easier to keep track of.
More details on system code derivation
Please merge this PR if your runbooks.yaml contains only the rules listed above.
If there are any other rules in it you wish to keep, close this PR and create a
new one that only removes the rules you don't need.
Many thanks
#engineering-insights