Open
Conversation
* Added unified script * Added logger * Added argparser * Updated readme * Initialized moving existing code to single config --------- Co-authored-by: louwenjjr <jorislouwen@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unified script and utilities for it, and for the various ways of using it (logger, argument parser etc).
This is a big step toward unified analysis code for feature generation. It is a refactoring of the existing scripts to a single function, where the parameters can be passed as arguments, thus making it significantly easier to add new data sources, it is then just one more line in the config, or a few extra arguments, instead of a whole new script.
Please see the unified script section added to the readme for details on how this new function can be used. Briefly, there are three ways:
Important to note: The old code is still present, as the config JSON to run all current public data (
INPROGRESS_public_data_config.json) is currently unfinished.Please see
batch_config.jsonfor a working example.The output is nearly identical to that of the existing code, with the only difference being that the unified code produces more files from some of the older datasets which (in the old code) lack output that was added to the code at a later stage.