Skip to content

fix: preserve custom Codex provider on fallback - #14

Merged
jiayuqi7813 merged 1 commit into
FishCodeTech:mainfrom
lucas-xu27:fix/codex-custom-endpoint-fallback
Aug 27, 2026
Merged

fix: preserve custom Codex provider on fallback#14
jiayuqi7813 merged 1 commit into
FishCodeTech:mainfrom
lucas-xu27:fix/codex-custom-endpoint-fallback

Conversation

@lucas-xu27

Copy link
Copy Markdown
Contributor

Summary

  • avoid Codex Desktop feature-disable flags for custom API endpoints, because the WebSocket-to-HTTPS fallback can discard the configured model provider and incorrectly call api.openai.com
  • use the stable endpoint envelope for normal execution, stdin execution, resume, and the real model health probe
  • add regression coverage for the endpoint command shape

Testing

  • .venv/bin/pytest -q -p no:cacheprovider tests/test_cli_executor.py -k 'codex_endpoint'
  • .venv/bin/pytest -q -p no:cacheprovider tests/test_cli_executor.py -k 'codex_execute_and_resume or driver_for_codex_keyed_profile_without_endpoint_still_injects_model'
  • verified a real custom Responses endpoint request returns OK

@jiayuqi7813

Copy link
Copy Markdown
Member

lgtm

@jiayuqi7813
jiayuqi7813 merged commit d1093c1 into FishCodeTech:main Aug 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants