Skip to content

Stabilize weighted adaptive-process-noise ratios - #4280

Closed
FlorianPfaff wants to merge 16 commits into
mainfrom
bugfix/adaptive-nis-weight-overflow-20260713
Closed

Stabilize weighted adaptive-process-noise ratios#4280
FlorianPfaff wants to merge 16 commits into
mainfrom
bugfix/adaptive-nis-weight-overflow-20260713

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • validate per-source NIS aggregation weights as nonnegative finite scalars
  • compute the weighted ratio with a scale-invariant online mean instead of sum(weight * ratio) / sum(weight)
  • add regressions for maximum finite weights and invalid source-weight payloads

Bug

RollingNISProcessNoiseAdapter.ratio() directly accumulated weighted sums. Equal weights near np.finfo(float).max overflowed both numerator and denominator, producing NaN for a mathematically finite mean. NaN weights were also silently skipped because NaN > 0 is false.

Testing

  • compiled the modified module and regression test with python -m py_compile
  • executed an isolated regression that verifies maximum finite equal weights return 3.0 and infinite weights raise ValueError
  • GitHub Actions should run the repository test matrix on this PR

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 24.17s
✅ JSON prettier 7 0 0 0 1.03s
✅ JSON v8r 7 0 0 4.32s
✅ MARKDOWN markdownlint 68 0 0 0 1.87s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.93s
✅ PYTHON black 1490 183 0 0 97.58s
✅ PYTHON isort 1490 328 0 0 2.66s
✅ REPOSITORY betterleaks yes no no 2.3s
✅ REPOSITORY checkov yes no no 55.94s
✅ REPOSITORY gitleaks yes no no 15.2s
✅ REPOSITORY git_diff yes no no 0.44s
✅ REPOSITORY secretlint yes no no 62.0s
✅ REPOSITORY syft yes no no 6.08s
✅ REPOSITORY trivy-sbom yes no no 8.22s
✅ REPOSITORY trufflehog yes no no 33.6s
✅ YAML prettier 11 0 0 0 0.76s
✅ YAML v8r 11 0 0 11.97s
✅ YAML yamllint 11 0 0 0.6s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff force-pushed the bugfix/adaptive-nis-weight-overflow-20260713 branch from 9535b9f to affd857 Compare July 13, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant