Preserve coroutine identity in deprecated async functions - #4283
Closed
FlorianPfaff wants to merge 17 commits into
Closed
Preserve coroutine identity in deprecated async functions#4283FlorianPfaff wants to merge 17 commits into
FlorianPfaff wants to merge 17 commits into
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
force-pushed
the
agent/preserve-async-deprecation
branch
from
July 13, 2026 16:37
3281986 to
8ab76bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
@deprecatedasync defwrapper instead of a synchronous wrapper returning a coroutineBug
The existing decorator always created a synchronous wrapper. Decorating an
async deffunction therefore madeinspect.iscoroutinefunction()returnFalse, even though calling the wrapper returned a coroutine. Async-aware frameworks and dispatch code can use that introspection result to decide whether a callable must be awaited, so the decorated function could be misclassified.Fix
Use a dedicated asynchronous wrapper when the decorated callable is a coroutine function. The wrapper emits the same
DeprecationWarningand awaits the original function, whilefunctools.wrapscontinues to preserve its public metadata.Validation
PYTHONPATH=. python -m pytest -q tests/test_deprecation_helper.py— 6 passedpython -m compileall -q pyrecest/deprecation.py