Skip to content

Preserve coroutine identity in deprecated async functions - #4283

Closed
FlorianPfaff wants to merge 17 commits into
mainfrom
agent/preserve-async-deprecation
Closed

Preserve coroutine identity in deprecated async functions#4283
FlorianPfaff wants to merge 17 commits into
mainfrom
agent/preserve-async-deprecation

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • detect coroutine functions in @deprecated
  • wrap async callables with an async def wrapper instead of a synchronous wrapper returning a coroutine
  • preserve the existing warning text, decorator metadata, and synchronous behavior
  • add a regression test covering coroutine introspection, execution, return value, and warning emission

Bug

The existing decorator always created a synchronous wrapper. Decorating an async def function therefore made inspect.iscoroutinefunction() return False, even though calling the wrapper returned a coroutine. Async-aware frameworks and dispatch code can use that introspection result to decide whether a callable must be awaited, so the decorated function could be misclassified.

Fix

Use a dedicated asynchronous wrapper when the decorated callable is a coroutine function. The wrapper emits the same DeprecationWarning and awaits the original function, while functools.wraps continues to preserve its public metadata.

Validation

  • PYTHONPATH=. python -m pytest -q tests/test_deprecation_helper.py — 6 passed
  • python -m compileall -q pyrecest/deprecation.py

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 19.61s
✅ JSON prettier 7 0 0 0 0.94s
✅ JSON v8r 7 0 0 4.03s
✅ MARKDOWN markdownlint 68 0 0 0 1.68s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.82s
✅ PYTHON black 1489 182 0 0 89.59s
✅ PYTHON isort 1489 327 0 0 2.17s
✅ REPOSITORY betterleaks yes no no 2.54s
✅ REPOSITORY checkov yes no no 50.98s
✅ REPOSITORY gitleaks yes no no 13.66s
✅ REPOSITORY git_diff yes no no 0.38s
✅ REPOSITORY secretlint yes no no 60.44s
✅ REPOSITORY syft yes no no 6.78s
✅ REPOSITORY trivy-sbom yes no no 7.79s
✅ REPOSITORY trufflehog yes no no 30.37s
✅ YAML prettier 11 0 0 0 0.65s
✅ YAML v8r 11 0 0 10.59s
✅ YAML yamllint 11 0 0 0.55s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff force-pushed the agent/preserve-async-deprecation branch from 3281986 to 8ab76bf Compare July 13, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant