Skip to content

Stabilize point-registration weight normalization - #4285

Closed
FlorianPfaff wants to merge 17 commits into
mainfrom
agent/stabilize-registration-weight-normalization
Closed

Stabilize point-registration weight normalization#4285
FlorianPfaff wants to merge 17 commits into
mainfrom
agent/stabilize-registration-weight-normalization

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • normalize point-registration weights after dividing by their maximum finite value
  • avoid overflow when individually finite weights have a non-finite direct sum
  • add a regression using the active backend's maximum finite floating-point weight

Bug

estimate_transform() normalized weights with weights / weights.sum(). For valid finite weights near the backend dtype maximum, the sum overflowed to infinity. The normalized weights then collapsed to zero, and the transform estimator incorrectly reported insufficient positive-weight support.

The fix first scales all non-negative weights by their maximum. The scaled values lie in [0, 1], so their sum remains finite for practical point-set sizes, while the resulting normalized weights are mathematically unchanged.

Validation

  • regression covers a translated two-point set with two maximum finite backend weights
  • the test checks that the correct translation is recovered rather than raising an identifiability error

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 23.79s
✅ JSON prettier 7 0 0 0 1.33s
✅ JSON v8r 7 0 0 3.67s
✅ MARKDOWN markdownlint 68 0 0 0 2.02s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.67s
✅ PYTHON black 1490 182 0 0 92.56s
✅ PYTHON isort 1490 328 0 0 2.6s
✅ REPOSITORY betterleaks yes no no 2.06s
✅ REPOSITORY checkov yes no no 52.88s
✅ REPOSITORY gitleaks yes no no 15.88s
✅ REPOSITORY git_diff yes no no 0.29s
✅ REPOSITORY secretlint yes no no 53.53s
✅ REPOSITORY syft yes no no 5.71s
✅ REPOSITORY trivy-sbom yes no no 6.46s
✅ REPOSITORY trufflehog yes no no 32.77s
✅ YAML prettier 11 0 0 0 0.76s
✅ YAML v8r 11 0 0 11.85s
✅ YAML yamllint 11 0 0 0.61s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff force-pushed the agent/stabilize-registration-weight-normalization branch from 76bb1b9 to eea58fa Compare July 13, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant