Stabilize discrete-state prior normalization - #4286
Closed
FlorianPfaff wants to merge 17 commits into
Closed
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
force-pushed
the
agent/stabilize-discrete-state-prior-normalization
branch
from
July 13, 2026 16:36
f743a93 to
f06a95e
Compare
Owner
Author
|
Closing as superseded by #4405, the newer current-main implementation of stable discrete-state prior normalization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Bug
The compatibility-layer probability validator normalized priors with
values / values.sum(). A valid vector can contain individually finite values whose sum overflows to infinity. For example,[finfo.max, finfo.max / 2]has a mathematically well-defined normalized ratio of2:1, but the direct floating-point sum isinf, so the implementation returned[0, 0]. The forward recursion then reported that the first emission had no prior-supported likelihood mass.Fix
Scale the non-negative vector by its largest entry before summing. All scaled entries are in
[0, 1], the relative probabilities are unchanged, and the positive-mass check remains explicit.Validation
[2/3, 1/3]tests/filters/test_discrete_state_probability_overflow.pymain: two commits ahead, zero behind; 7 production-line changes and one focused regression fileThe full repository test matrix is delegated to GitHub Actions.