Reject non-finite sliding-window smoother weights - #4292
Closed
FlorianPfaff wants to merge 17 commits into
Closed
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
force-pushed
the
agent/reject-nonfinite-sliding-window-weights-20260713
branch
from
July 13, 2026 16:31
e7cf6bc to
f5ef1e8
Compare
Owner
Author
|
Closing as an obsolete conflicted stack. This branch carries a large inherited commit chain on an old base, so the focused change cannot be reviewed or repaired safely in place. Recreate the small fix from current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
SlidingWindowManifoldMeanSmoother.window_weightsfor finiteness before sign and mass checksNaN, positive infinity, and negative infinity with a clearValueErrorBug
SlidingWindowManifoldMeanSmootherchecked only whetherwindow_weightswere negative and whether their sum was positive.Those checks do not reject non-finite values:
NaNare false, so a vector containingNaNpassed both checks+infhad positive total mass and was acceptedWhen an active window was normalized, these values produced
NaNweights (NaN / NaNorinf / inf) and consequently non-finite smoothed states.Fix
Require every configured window weight to be finite using the active backend before applying the existing non-negativity and positive-mass validation.
Validation
NaNand+infand normalization produces non-finite weightsNaN,+inf, and-infmainand zero behindThe full multi-backend test matrix is delegated to GitHub Actions.