Stabilize piecewise-constant weight normalization - #4294
Closed
FlorianPfaff wants to merge 17 commits into
Closed
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
force-pushed
the
agent/stabilize-piecewise-constant-weights-20260713
branch
from
July 13, 2026 16:30
261a4c5 to
340843f
Compare
Owner
Author
|
Closing as duplicate of #4295. The latter carries the same piecewise-constant normalization repair on the preferred branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
mean * 2πdenominatorBug
PiecewiseConstantDistributionnormalized constructor weights withValid individually finite weights near the dtype maximum can overflow while computing the mean or while multiplying the mean by
2π. The resulting infinite denominator collapses every stored density weight to zero. For example,[finfo.max, finfo.max / 2]should retain a 2:1 mass ratio, but the current implementation produces[0, 0].Fix
Divide all weights by their maximum finite value first. The scaled values lie in
[0, 1], so their mean and subsequent normalization remain finite while the relative weights are unchanged.Validation
[0, 0]for[finfo.max, finfo.max / 2][2/(3π), 1/(3π)]and integrates to onemain, zero behind; final diff is 8 production-line changes plus one focused 23-line regressionThe full multi-backend test matrix is delegated to GitHub Actions.