Skip to content

Reject boolean cardinality-prior parameters - #4296

Closed
FlorianPfaff wants to merge 17 commits into
mainfrom
agent/reject-cardinality-bool-parameters-20260713
Closed

Reject boolean cardinality-prior parameters#4296
FlorianPfaff wants to merge 17 commits into
mainfrom
agent/reject-cardinality-bool-parameters-20260713

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • validate Pitman–Yor strength and discount as finite real scalars before conversion
  • reject Python and NumPy booleans instead of silently interpreting them as 1.0 or 0.0
  • add focused regression coverage for both parameters

Root cause

PitmanYorCardinalityPrior.__post_init__ called float(...) directly. In Python, float(True) == 1.0 and float(False) == 0.0, so boolean configuration values could pass parameter validation and change the prior without an error.

Testing

  • added targeted pytest cases for Python and NumPy boolean scalars
  • local repository execution was unavailable in the connector runtime; GitHub Actions is the source of truth for the full test suite

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 18.49s
✅ JSON prettier 7 0 0 0 1.03s
✅ JSON v8r 7 0 0 2.98s
✅ MARKDOWN markdownlint 68 0 0 0 1.45s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.66s
✅ PYTHON black 1489 182 0 0 68.5s
✅ PYTHON isort 1489 327 0 0 2.01s
✅ REPOSITORY betterleaks yes no no 2.23s
✅ REPOSITORY checkov yes no no 43.15s
✅ REPOSITORY gitleaks yes no no 11.02s
✅ REPOSITORY git_diff yes no no 0.27s
✅ REPOSITORY secretlint yes no no 47.11s
✅ REPOSITORY syft yes no no 4.47s
✅ REPOSITORY trivy-sbom yes no no 4.33s
✅ REPOSITORY trufflehog yes no no 23.66s
✅ YAML prettier 11 0 0 0 0.55s
✅ YAML v8r 11 0 0 9.07s
✅ YAML yamllint 11 0 0 0.41s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff force-pushed the agent/reject-cardinality-bool-parameters-20260713 branch from f8b4fad to e667352 Compare July 13, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant