Handle subnormal mixture weights without XLA flush-to-zero - #5414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
AbstractMixturevalidates explicit weights on the host, but then determines nonzero components and normalizes using backend comparisons/reductions. On JAX/XLA, representable positive float64 subnormals can be flushed to zero during those operations. A valid mixture such as weights proportional to[2e-311, 1e-311]is therefore rejected as having no nonzero components; the existing backend fallback also sees a zeromaxand cannot recover the ratio.This is inconsistent with the robust XLA-subnormal handling already used by
AbstractDiracDistribution.Fix
Regression
Adds a focused test with two positive float64 subnormal weights in a 2:1 ratio. The regression verifies that neither component is pruned and that the resulting weights are
[2/3, 1/3].The branch is based on current
mainafter #5411 and has no overlap with the open PR queue.