Skip to content

Reject invalid replay-grid log likelihoods - #5430

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix/replay-grid-nonfinite-log-likelihood
Aug 25, 2026
Merged

Reject invalid replay-grid log likelihoods#5430
FlorianPfaff merged 2 commits into
mainfrom
fix/replay-grid-nonfinite-log-likelihood

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • reject NaN and +inf replay-grid log-likelihood entries instead of silently treating them as zero mass
  • preserve -inf as the valid representation of zero likelihood
  • apply the same contract to both grid lookup/update coercion and grid_proposal_weights
  • add focused regressions covering invalid non-finite values and the valid -inf case

This aligns replay-grid likelihood semantics with PyRecEst's discrete-state log-likelihood validation and prevents numerical failures from being silently converted into impossible observations.

@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) August 25, 2026 10:31
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 7.95s
✅ JSON prettier 7 0 0 0 0.61s
✅ JSON v8r 7 0 0 4.05s
✅ MARKDOWN markdownlint 68 0 0 0 2.1s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.4s
✅ PYTHON black 2022 5 0 0 57.28s
✅ PYTHON isort 2022 6 0 0 2.81s
✅ REPOSITORY betterleaks yes no no 1.32s
✅ REPOSITORY checkov yes no no 34.21s
✅ REPOSITORY git_diff yes no no 0.17s
✅ REPOSITORY secretlint yes no no 99.72s
✅ REPOSITORY syft yes no no 2.87s
✅ REPOSITORY trivy-sbom yes no no 2.48s
✅ YAML prettier 11 0 0 0 0.97s
✅ YAML v8r 11 0 0 16.47s
✅ YAML yamllint 11 0 0 0.74s

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: MAKEFILE_CHECKMAKE. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff merged commit c44ef77 into main Aug 25, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant