Skip to content

Make DP birth updates atomic on validation failures - #5440

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix/dp-birth-update-atomicity
Aug 27, 2026
Merged

Make DP birth updates atomic on validation failures#5440
FlorianPfaff merged 2 commits into
mainfrom
fix/dp-birth-update-atomicity

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

Fixes a state-consistency bug in DirichletProcessBirthMultiBernoulliTracker: birth-atom pruning/cap validation and Bernoulli construction could fail only after a new or reused DP birth atom had already been committed, leaving partial tracker state behind.

Changes

  • validate DP birth pruning/cap controls before mutating birth atoms
  • update reused atoms on a copy and commit only after component construction succeeds
  • delay diagnostics/state commits until all failure-prone work completes
  • add regressions for invalid atom caps, invalid pruning thresholds, and late Bernoulli-construction failures

Expected behavior

Failed birth updates now leave both birth_atoms and last_birth_diagnostics unchanged. Successful and clutter-only birth decisions retain their existing behavior.

@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) August 27, 2026 09:53
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 5.05s
✅ JSON prettier 7 0 0 0 0.47s
✅ JSON v8r 7 0 0 3.9s
✅ MARKDOWN markdownlint 68 0 0 0 1.31s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.29s
✅ PYTHON black 2026 6 0 0 46.36s
✅ PYTHON isort 2026 9 0 0 2.0s
✅ REPOSITORY betterleaks yes no no 1.03s
✅ REPOSITORY checkov yes no no 29.46s
✅ REPOSITORY git_diff yes no no 0.09s
✅ REPOSITORY secretlint yes no no 74.92s
✅ REPOSITORY syft yes no no 1.95s
✅ REPOSITORY trivy-sbom yes no no 1.74s
✅ YAML prettier 11 0 0 0 0.39s
✅ YAML v8r 11 0 0 8.99s
✅ YAML yamllint 11 0 0 0.52s

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: MAKEFILE_CHECKMAKE. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff merged commit dd227b2 into main Aug 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant