Skip to content

Fix Fourier RHM validation and prediction atomicity - #5443

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix/fourier-rhm-validation-atomicity
Aug 27, 2026
Merged

Fix Fourier RHM validation and prediction atomicity#5443
FlorianPfaff merged 2 commits into
mainfrom
fix/fourier-rhm-validation-atomicity

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • make FourierRHMTracker.predict_linear() atomic when process-noise validation fails
  • reject non-finite state/measurement inputs and scalar UKF/RHM controls before they can poison the recursion
  • validate covariance-like inputs as finite, symmetric positive-semidefinite matrices instead of silently symmetrizing them
  • add regressions for the partial-state update, asymmetric process noise, non-finite measurement noise, and NaN scalar controls

Bug

predict_linear() previously called _set_state_vector() before validating sys_noise. An invalid process-noise shape therefore raised after the state had advanced, leaving the tracker with a new state and old covariance. Covariance-like inputs were also silently symmetrized, while NaN scalar controls passed checks such as value < 0.0.

Validation

Local checkout/test execution is unavailable in this environment, so the focused regressions are included for GitHub CI to execute. The branch is based on current main (dd227b27).

@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) August 27, 2026 15:09
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 7.93s
✅ JSON prettier 7 0 0 0 0.66s
✅ JSON v8r 7 0 0 5.17s
✅ MARKDOWN markdownlint 68 0 0 0 1.88s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.41s
✅ PYTHON black 2027 7 0 0 57.33s
✅ PYTHON isort 2027 10 0 0 2.84s
✅ REPOSITORY betterleaks yes no no 1.04s
✅ REPOSITORY checkov yes no no 33.2s
✅ REPOSITORY git_diff yes no no 0.13s
✅ REPOSITORY secretlint yes no no 99.31s
✅ REPOSITORY syft yes no no 2.73s
✅ REPOSITORY trivy-sbom yes no no 2.71s
✅ YAML prettier 11 0 0 0 0.6s
✅ YAML v8r 11 0 0 14.98s
✅ YAML yamllint 11 0 0 0.89s

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: MAKEFILE_CHECKMAKE. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff merged commit 2b2d59b into main Aug 27, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant