Reject invalid velocity-aided heading controls - #5449
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
enabled auto-merge (squash)
August 28, 2026 07:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
speed_threshold,orientation_offset,heading_noise_variance, andminimum_heading_variancevalues before they can contaminate heading updatesapply_heading_on_prediction,use_heading_constraint, and the per-update heading override instead of silently coercing values such as"False"toTrueWhy
The previous code used
float(...)plus sign checks for heading scalars andbool(...)for public flags. As a result, NaN values passed validation, and a value such asuse_heading_constraint="False"enabled the constraint because non-empty strings are truthy. Both can silently alter or corrupt filtering behavior.Testing
Added focused pytest regressions under
tests/filters/test_velocity_aided_mem_qkf_validation.py. Full repository CI should validate backend/lint compatibility.