Reject non-boolean circular Fourier scaling flags - #5450
Merged
Conversation
FlorianPfaff
enabled auto-merge (squash)
August 28, 2026 07:41
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
CircularFourierDistribution.multiplied_by_nas an actual boolean instead of relying on Python truthinessstore_values_multiplied_by_nin both Fourier factory pathsNone, factory calls, and NumPy booleansWhy
The current implementation stores these public scaling flags without validation. Values such as
multiplied_by_n="False"are truthy in Python, so they silently enable coefficient scaling and changepdf()/integrate()results instead of behaving as false or failing fast. The factory flag has the same problem and can silently choose the wrong coefficient normalization.The fix uses a small distribution-local strict boolean validator so it does not introduce a
distributions -> models -> distributionsimport cycle.Testing
Added focused regressions in
tests/distributions/test_circular_fourier_bool_validation.py. Full repository CI validates backend and documentation compatibility.