Harden VBRM validation and make prediction failures atomic - #5453
Merged
Conversation
FlorianPfaff
enabled auto-merge (squash)
August 28, 2026 13:23
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
num_iterationsuse the same strict positive-integer contract as constructionBugs fixed
NaN/Infcould pass positive/non-negative checks because comparisons such asnan <= 0are false.predict_linear()updated kinematics/orientation and scaled inverse-gamma parameters before checking whether forgetting drove alpha to<= 1; an exception therefore left a partially advanced tracker.update(..., num_iterations=...)usedint(...), silently accepting values such asTrue,1.5, and"2", unlike the constructor.The branch is based on current
mainateec266f55c10304e68172057e034364ca7314375and intentionally avoids the separate open reflection-flag fix in #5452.