Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions .agent-loop/LOOP_STATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,17 @@

## Current State

- Active initiative in this worktree: `WS-ART-001` - Immutable Artifact Storage
- Active planning chunk: `WS-ART-001-OBJECT-STORAGE-AMENDMENT`
- Active initiative: none
- Active planning chunk: none
- Active implementation chunk: none
- Branch: `codex/ws-art-001-object-storage-planning-amendment`
- Branch: `codex/ws-art-001-object-storage-amendment-post-merge-memory`
- Worktree: `/home/abiorh/flow/workstream`
- Latest integrated `main` merge commit: `ad71c7e` from PR #119.
- Status: PR #120's branch integrates AUTH-05B PR #119 through merge SHA
`1545d9aa37329c13efa53f7ad9076ffca1fbfaf6`. The bounded three-file conflict
resolution passed deterministic proof and every required `gpt-5.5` high
reviewer track; all reviewer sessions are closed.
- Current gate: publish the evidence-bound branch, wait for fresh GitHub checks
and external review, then stop for explicit human review and merge approval.
No storage runtime implementation is active.
- Latest integrated `main` merge commit: `440825642e9788d9aad7858dc4afc7cec07c9d44`
from PR #120.
- Status: the AWS-first object-storage planning amendment merged through PR
#120 on 2026-07-15. No artifact implementation chunk is active.
- Current gate: publish and merge this post-merge memory update, then stop.
Do not start artifact implementation from this memory branch.
- Scope checkpoint: AWS S3 is the only v0.1 production provider; MinIO is
local/CI S3 protocol proof; LocalStorage is focused development/test; R2 and
Flow Node are deferred. Product modules receive narrow artifact capabilities,
Expand All @@ -23,8 +21,8 @@
including 21 artifact permissions. AUTH-07 registers them, AUTH-08 defines
applicable Operator grants, AUTH-09 provisions fixed service principals, and
each owning WS-ART feature chunk activates only its own canonical actions.
- Next artifact chunk: `WS-ART-001-02A1` remains inactive until this amendment
merges and the user gives a separate explicit start signal.
- Next artifact chunk: `WS-ART-001-02A1` remains inactive until this memory
update merges and the user gives a separate explicit start signal.
- Parallel authorization work: `WS-AUTH-001-05B` merged through PR #119 as
`ad71c7e`. `WS-AUTH-001-06` remains inactive pending post-merge memory and a
separate explicit user start.
Expand Down
27 changes: 27 additions & 0 deletions .agent-loop/REVIEW_LOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
# Review Log

## 2026-07-15 - WS-ART-001 Object Storage Amendment Merged

PR #120 merged into `main` as
`440825642e9788d9aad7858dc4afc7cec07c9d44` at
`2026-07-15T00:11:33Z`.

Reviewed planning SHA:
`1545d9aa37329c13efa53f7ad9076ffca1fbfaf6`.

Final evidence-bound branch head:
`f57dad846f7170680ffcdc7bc4c7aa6585d87813`.

Agent Gates and Backend passed on the final head. CodeRabbit's status context
was green, but its published comment states that the fresh review was skipped
because the account review limit had been reached; no CodeRabbit findings are
claimed. The user explicitly approved and merged the PR.

The merge establishes the AWS-first artifact-storage implementation sequence.
It changes no artifact runtime. `WS-ART-001-02A1` remains inactive until this
post-merge memory update merges and the user gives a separate explicit start.

Evidence: `.agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/reviews/WS-ART-001-OBJECT-STORAGE-AMENDMENT-post-merge-memory-internal-review-evidence.md`

External review response: `.agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/reviews/WS-ART-001-OBJECT-STORAGE-AMENDMENT-post-merge-memory-external-review-response.md`

Trust bundle: `.agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/reviews/WS-ART-001-OBJECT-STORAGE-AMENDMENT-post-merge-memory-pr-trust-bundle.md`

## 2026-07-14 - WS-ART-001 Object Storage Amendment Internal Review Passed

Planning candidate `74301e87d1490506b11e1546245f389c3211d12b` passed
Expand Down
14 changes: 7 additions & 7 deletions .agent-loop/WORK_QUEUE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@

## In Progress

| Chunk | Title | Risk | Status |
|---|---|---:|---|
| `WS-ART-001-OBJECT-STORAGE-AMENDMENT` | AWS-First Object Storage Planning Amendment | L1 | Publication branch updated from `main`; merge-resolution review pending |
None.

## Planned Next

Expand All @@ -14,7 +12,7 @@
| `WS-QUAL-001-01B2` | Baseline Evidence And CI Ratchet | L1 | Paused for AUTH priority; no valid replacement baseline yet |
| `WS-QUAL-001-02` | Project Service Coverage | L1 | Inactive until 01B2 merge/memory plus explicit user start |
| `WS-POL-002-04` | Locked Runtime Execution And Routing Hardening | L1 | Inactive pending relevant authorization proof and a separate explicit user start |
| `WS-ART-001-02A1` | External Service Adapter Foundation | L1 | Proposed only after amendment merge and explicit user start |
| `WS-ART-001-02A1` | External Service Adapter Foundation | L1 | Inactive until amendment post-merge memory and a separate explicit user start |
| `WS-ART-001-02A2` | Committed Source And Local Preparation | L1 | Inactive until 02A1 merge and explicit user start |
| `WS-ART-001-02A3` | ArtifactStore v2 Local Clean Cut | L1 | Inactive until 02A2 merge and explicit user start |
| `WS-ART-001-02B1` | S3-Compatible MinIO And AWS | L1 | Inactive until 02A3 merge and explicit user start |
Expand Down Expand Up @@ -66,6 +64,7 @@
| `WS-AUTH-001-CAT` | Action And Resource Catalogue Reconciliation | L1 | Merged through PR #117 as `4c5d4fc` on 2026-07-14 |
| `WS-AUTH-001-CAT-MEMORY` | Catalogue Post-Merge Memory | L1 | Merged through PR #118 as `eba7e2b` on 2026-07-14 |
| `WS-AUTH-001-05B` | Authority Idempotency And Invalidation Foundation | L1 | Merged through PR #119 as `ad71c7e` on 2026-07-14 |
| `WS-ART-001-OBJECT-STORAGE-AMENDMENT` | AWS-First Object Storage Planning Amendment | L1 | Merged through PR #120 as `4408256` on 2026-07-15 |

## Proposed Next

Expand All @@ -76,9 +75,10 @@ Do not start AUTH-06 or POL-002-04 automatically.
Coverage R10 merged through PR #108. Do not start 01B2, chunk 02, or another
coverage implementation chunk from this worktree.

`WS-ART-001-01` is merged. The parallel planning amendment makes AWS S3 the
only v0.1 production provider. R2 and Flow Node are deferred. Do not start 02A1
until the amendment merges and the user gives a separate explicit start signal.
`WS-ART-001-01` and the AWS-first planning amendment are merged. AWS S3 is the
only v0.1 production provider; R2 and Flow Node are deferred. Do not start 02A1
until this post-merge memory update merges and the user gives a separate
explicit start signal.

Coverage work proceeds independently in its own worktree and is not owned by
this AUTH queue update.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ Each chunk is one PR. No later chunk starts automatically.
|---|---|---:|---|
| `WS-ART-001-PLAN` | Original artifact planning. | L1 | Merged through PR #97 |
| `WS-ART-001-01` | Artifact domain and LocalStorage v1 foundation. | L1 | Merged through PR #101 |
| `WS-ART-001-OBJECT-STORAGE-AMENDMENT` | Make AWS S3 the v0.1 production provider with MinIO local/CI protocol proof; keep optional providers outside v0.1. | L1 | Active planning only |
| `WS-ART-001-02A1` | Install only ADR 0014's small typed external-service adapter/factory foundation without migrating a capability. | L1 | Proposed after amendment merge and explicit start |
| `WS-ART-001-OBJECT-STORAGE-AMENDMENT` | Make AWS S3 the v0.1 production provider with MinIO local/CI protocol proof; keep optional providers outside v0.1. | L1 | Merged through PR #120 as `4408256` on 2026-07-15 |
| `WS-ART-001-02A1` | Install only ADR 0014's small typed external-service adapter/factory foundation without migrating a capability. | L1 | Inactive until amendment post-merge memory and a separate explicit user start |
| `WS-ART-001-02A2` | Add bounded committed-source preparation and inactive scratch-cleanup mechanics without changing the active v1 port. | L1 | Proposed after 02A1 |
| `WS-ART-001-02A3` | Replace ArtifactStore v1 with byte-only v2, activate API-startup and Celery Beat scratch cleanup, migrate schema/callers/factory, and remove `flow_node` in one atomic clean cut. | L1 | Proposed after 02A2 |
| `WS-ART-001-02B1` | Implement the S3-compatible adapter, MinIO integration, and AWS S3 production profile. | L1 | Proposed after 02A3 |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

## Current State

Original planning merged through PR #97 and artifact/LocalStorage foundation
merged through PR #101. No artifact implementation chunk is active.
Original planning merged through PR #97, the artifact/LocalStorage foundation
merged through PR #101, and the AWS-first object-storage amendment merged
through PR #120 on 2026-07-15 as `4408256`. No artifact implementation chunk
is active.

The Flow Node-focused amendment candidate `6cc422d` passed deterministic checks
but failed internal review on recovery/API completeness. Before repair, the user
Expand All @@ -22,28 +24,27 @@ approval or reusable evidence. Its source remains on branch

## Active Work

`WS-ART-001-OBJECT-STORAGE-AMENDMENT` is planning-only. It updates intent,
architecture, ADR/spec, chunk contracts, durable memory, and deterministic
stale-contract protection. It does not edit runtime code, configure AWS S3,
operate Flow Node, add a deferred provider, or activate artifact routes.
None. The amendment's reviewed planning SHA was `1545d9a`; its final
evidence-bound branch head was `f57dad8`. The merged plan does not itself
configure AWS S3, operate Flow Node, add a deferred provider, or activate
artifact routes.

## Next Proposed Chunk

`WS-ART-001-02A1` is proposed after this amendment merges and the user starts it
explicitly. It installs only the shared typed external-service adapter/factory
foundation. `02A2` adds committed-source preparation and narrows LocalStorage
internals without changing the active port. `02A3` performs the atomic
ArtifactStore v2/LocalStorage/schema cut and removes `flow_node`. `02B1` then
owns MinIO and AWS S3. There is no active R2 chunk.
`WS-ART-001-02A1` remains inactive until this post-merge memory update merges
and the user starts it explicitly. It installs only the shared typed
external-service adapter/factory foundation. `02A2` adds committed-source
preparation and narrows LocalStorage internals without changing the active
port. `02A3` performs the atomic ArtifactStore v2/LocalStorage/schema cut and
removes `flow_node`. `02B1` then owns MinIO and AWS S3. There is no active R2
chunk.

## Gate

Merge SHA `1545d9aa37329c13efa53f7ad9076ffca1fbfaf6` received every
required internal track after `main` advanced through AUTH-05B PR #119: senior
engineering, architecture, QA/test, security/auth, product/ops, reuse/dedup, CI
integrity, test delta, and docs. Valid evidence/status findings are closed in
the permitted post-review files. Every reviewer used `gpt-5.5` with high
reasoning and every reviewer session is closed.
PR #120 is merged. Agent Gates and Backend passed on final branch head
`f57dad8`. CodeRabbit did not perform a fresh final-head review because its
review limit was reached; that fact is recorded separately and no CodeRabbit
findings are claimed.

Deterministic proof passes: Ruff; stale artifact, authorization, and Workstream
wording scans; loop-memory state; 75 changed Markdown links; diff hygiene; the
Expand All @@ -54,7 +55,10 @@ Evidence:

- `reviews/WS-ART-001-OBJECT-STORAGE-AMENDMENT-internal-review-evidence.md`
- `reviews/WS-ART-001-OBJECT-STORAGE-AMENDMENT-pr-trust-bundle.md`
- `reviews/WS-ART-001-OBJECT-STORAGE-AMENDMENT-external-review-response.md`
- `reviews/WS-ART-001-OBJECT-STORAGE-AMENDMENT-post-merge-memory-internal-review-evidence.md`
- `reviews/WS-ART-001-OBJECT-STORAGE-AMENDMENT-post-merge-memory-external-review-response.md`
- `reviews/WS-ART-001-OBJECT-STORAGE-AMENDMENT-post-merge-memory-pr-trust-bundle.md`

The current gate is external review and explicit human merge approval. GitHub
checks and CodeRabbit remain separate from internal review. Do not merge without
the user's approval, and do not start `WS-ART-001-02A1` automatically.
The current gate is to merge this post-merge memory update and stop. Do not
start `WS-ART-001-02A1` automatically.
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Chunk Contract: WS-ART-001-02A1 External Service Adapter Foundation

Initiative: `WS-ART-001` | Risk: L1 | Status: Proposed after amendment merge
Initiative: `WS-ART-001` | Risk: L1 | Status: Inactive until amendment
post-merge memory and a separate explicit user start

Artifact contract phase: `foundation`

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Chunk Contract: WS-ART-001 Object Storage Planning Amendment

Initiative: `WS-ART-001` | Risk: L1 | Status: Active planning only
Initiative: `WS-ART-001` | Risk: L1 | Status: Merged through PR #120 as
`4408256` on 2026-07-15

## Goal

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# External Review Response: WS-ART-001 Object Storage Amendment

## Pull Request

- PR: `https://github.com/Flow-Research/workstream/pull/120`
- Final branch head: `f57dad846f7170680ffcdc7bc4c7aa6585d87813`
- Merge commit: `440825642e9788d9aad7858dc4afc7cec07c9d44`
- Merged at: `2026-07-15T00:11:33Z`

## GitHub Checks

| Check | Result |
|---|---:|
| Agent Gates | PASS |
| Backend | PASS |

## CodeRabbit

CodeRabbit's status context appeared green, but its final published comment
states that the review limit had been reached and that it could not start the
review of `ad71c7e...f57dad8`.

Therefore:

- no fresh CodeRabbit review is claimed;
- no CodeRabbit findings were posted for the final head;
- CodeRabbit did not replace or supplement the completed internal review for
this merge decision.

## Human Checkpoint

The user explicitly approved and merged PR #120. This record does not authorize
`WS-ART-001-02A1`; that chunk still requires a separate explicit start signal
after this post-merge memory update merges.
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# External Review Response: WS-ART-001 Amendment Post-Merge Memory

## Pull Request

- PR: `https://github.com/Flow-Research/workstream/pull/123`
- Reviewed head: `9571f1ff4b0e854364b9c70e12d0aae8638f0ba6`

## Comments Addressed

- CodeRabbit correctly found that the post-merge `REVIEW_LOG.md` entry linked
to the amendment's earlier internal-review evidence instead of the dedicated
post-merge-memory evidence.
- The evidence link was corrected. The adjacent external-response and trust-
bundle links were also corrected to their post-merge-memory records.
- The PR description was expanded to include the repository's required trust-
bundle sections. CodeRabbit's description check now passes.

## Comments Deferred

None.

## Human Decisions Needed

The user retains the merge decision for PR #123. This response does not start
`WS-ART-001-02A1`.

## Commands Rerun

The final command results and exact reviewed revision are recorded in the
post-merge-memory internal-review evidence and PR trust bundle.

## Remaining Risks

None identified for this memory-only correction.
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
# Internal Review Evidence: WS-ART-001 Object Storage Amendment Post-Merge Memory

## Chunk

`WS-ART-001-OBJECT-STORAGE-AMENDMENT` post-merge memory update

open sub-agent sessions: none

valid findings addressed: yes

## Reviewed Revision

Reviewed code SHA: e1fc4818cb5d0d45f280cbe3b181a4795da4df0f

Reviewed at: 2026-07-15T01:01:40Z

Reviewer run IDs: senior-engineering=019f6346-4625-79d3-8b19-5de960d6ab93; QA/test=019f6346-4e1b-7453-8924-c2d7affd9ea9; security/auth=019f6346-57d2-7963-b338-4b11c1709207; product/ops=019f6346-6042-7431-9c04-a549473c8f86; architecture=019f6346-6ab9-7692-8b17-bd6f9052779f; docs=019f6346-7301-75b1-a860-9a48461acdab

After the reviewed SHA, only evidence and status files may change:

- `.agent-loop/initiatives/**/reviews/**`
- `.agent-loop/LOOP_STATE.md`
- `.agent-loop/initiatives/**/STATUS.md`
- `docs/internal_reviews/**`

## Reviewed Change

- Recorded PR #120 as merged through
`440825642e9788d9aad7858dc4afc7cec07c9d44` at
`2026-07-15T00:11:33Z`.
- Recorded reviewed planning SHA `1545d9a` and final evidence-bound branch head
`f57dad8`.
- Recorded Agent Gates and Backend as passed while stating accurately that
CodeRabbit skipped the final-head review because its review limit was reached.
- Moved the amendment to completed and aligned its chunk contract and chunk map.
- Kept `WS-ART-001-02A1` inactive until this memory update merges and the user
gives a separate explicit start signal.
- Changed no runtime, architecture implementation, workflow, test, dependency,
migration, API, or product file.

## Reviewer Results

| Reviewer | Result | Blocking findings | Notes |
|---|---:|---|---|
| senior engineering | PASS AFTER FIXES | None | Found stale evidence binding and missing initiative-local external-response link; both were corrected. |
| QA/test | PASS AFTER FIXES | None | Confirmed exact links, inactive start gates, memory-only scope, and the evidence/status repairs. |
| security/auth | PASS AFTER FIXES | None | Confirmed exact-head evidence reconciliation and no authority/runtime change. |
| product/ops | PASS AFTER FIXES | None | Confirmed no product lifecycle change and no automatic next-chunk activation. |
| architecture | PASS AFTER FIXES | None | Confirmed memory-only boundaries, the repaired status link, and no adapter/runtime activation. |
| docs | PASS AFTER FIXES | None | Confirmed separated review records, corrected SHA, and corrected file-count wording. |
| CI integrity | N/A - WITH APPROVED REASON | None | No workflow, package script, dependency, lint, typecheck, test, or coverage configuration changed. |
| test delta | N/A - WITH APPROVED REASON | None | No test file or assertion changed. |
| reuse/dedup | N/A - WITH APPROVED REASON | None | No helper, abstraction, implementation, or reusable code changed. |

## Valid Findings Addressed

- Changed the amendment contract status from active planning to merged.
- Changed the amendment chunk-map row from active planning to merged.
- Changed both `02A1` initiative-local status locations to require this
post-merge memory plus a separate explicit user start.
- Corrected `REVIEW_LOG.md` to reference the post-merge internal evidence,
external response, and trust bundle.
- Added the missing post-merge external-response link to initiative `STATUS.md`.
- Rebound this evidence and the trust bundle to reviewed code SHA `e1fc481` and
corrected the reviewed file count.
- Ran a broad stale-state scan after the repairs; no current amendment or
`02A1` pre-merge wording remains.

## Commands Run

```bash
git diff --check
python3 scripts/check_loop_memory_state.py
python3 scripts/check_stale_artifact_contracts.py
python3 scripts/check_stale_authorization_docs.py
python3 scripts/check_stale_workstream_wording.py
python3 scripts/check_markdown_links.py --changed-only origin/main...HEAD
test -z "$(git diff --name-only origin/main...HEAD -- backend/app backend/alembic backend/pyproject.toml docker-compose.yml .github scripts)"
```

Results: all passed. The reviewed diff contains twelve Markdown files under
`.agent-loop/` and no runtime or architecture implementation path.

## Stop Condition

Merge this memory-only PR and stop. Do not start `WS-ART-001-02A1` without a
separate explicit user start after this memory update merges.
Loading
Loading