REV-04C: compose hidden shared acceptance and TASK effects

[Abiorh001]

Change

REV-04C connects FinalAcceptance, TASK completion and submitter contribution/awards in one caller-owned transaction. Replay returns the original complete facts and rejects missing effects instead of repairing them.

Intent, scope, design and activation prerequisites.

Design and scope

Canonical fence → TASK locks/validation → actual stored source validation → acceptance insert or exact read → TASK terminal effects → CON/complete frozen awards. The same operational new/replay disposition reaches every participant.

The existing acceptance source contract moved into REV's public API; the private schema was removed with all callers updated, without an alias. No migration, production registration, route, action activation, false-guide activation, reviewer contribution, payment or artifact-byte access is added. Current roadmap and linked specifications/navigation are reconciled; no local spreadsheet exports are present.

Evidence

Current head: 6aae0d4b34293b865e747a5809f85771cf1dc393.

• Exact-head affected PostgreSQL proof: 4 passed, including isolated replay-guard removal and both TASK prestates. Isolated database cleanup confirmed.
• Exact-head pure repair proof: 32 passed.
• Ruff, module/authorization/test-structure boundaries, ownership, markdown links, stale wording and Commitrail checks passed. No gate, runner, cap, partition algorithm, dependency or workflow weakening.
• Hosted Backend passed: 8,613 unique tests completed, zero skipped or deselected. Run 37259906446, attempt 2. All required GitHub checks pass.
• GitHub tested synthetic merge 81f81e59; its tree exactly matches reviewed head 6aae0d4b. The downloaded final evidence passed the canonical validator from an exact synthetic-merge checkout, including independent test collection and evidence hashes.
• Task A initially hit the unchanged 1,200-second deadline after all 528 test nodes completed. Independent diagnosis justified one failed-jobs rerun; it passed without code or configuration changes. The canonical merger selected that successful attempt plus the eight successful original lanes. Slowest accepted lane runner: 1,119.729 seconds. Hosted timing remains above the advisory target.

Test delta

Adds strict shared contracts, production-unreachability, source/lineage controls, partial-state rejection, rollback and concurrent shared-owner winner proof. Direct-CON self-classification concurrency is replaced by shared-owner concurrency with retained winner-ID assertions. Moved TASK contract assertions are retained, including frozen/closed values and exact exports. No skips or weakened required proof.

Impact-routed review

All entries below bind the current head. Summaries mirror independent review evidence; they do not replace it.

Track	Result	Proof and limits
Architecture / reuse	PASS	Owner graph and unchanged production-code inspection; injected reverse dependency fails the cycle guard.
Security	PASS	Exact stored-source/lineage substitution and hidden-entry proof; future AUTH/currentness remains unavailable.
QA / test delta	PASS	Exact PostgreSQL repaired guard-removal probe and both mechanical prestates; retained contract assertions.
Documentation / product operations	PASS	Current owner/navigation claims reconciled; both policy branches and activation prerequisites preserved.
CI integrity	PASS	Exact hosted manifest: 8,613 unique completed tests, zero skips/deselections; all hashes and cleanup verified, correct latest-attempt selection, unchanged gates/caps.

External review

CodeRabbit substantively reviewed exact head 6aae0d4b and found no actionable findings; no review threads remain unresolved. Its docstring-coverage note is advisory, not a repository gate.

Remaining risks and human focus

This is a hidden mechanical participant, not a live acceptance route or the complete authorized operation. Before production entry, evolve this same input/schema to mandatory verified AUTH custody; add database-enforced complete-effect closure, shared audit/outbox and fulfillment-root custody; prove both TASK-before-CHECKERS currentness race orders. Storage fixtures are not authority, and positive automated acceptance remains unavailable while false guide activation is blocked.

Review no-repair replay, exact source ownership and caller rollback, and the distinction between internal composition and activation. The next boundary is hidden routing handlers, followed by the named activation and live-integration gates.

Human merge ownership

• Eligible human reviewed the final head and accepts its remaining limits.
• User explicitly approved this PR for merge.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3c99fae1-7a4c-4094-a0fc-fbf25886712a

📥 Commits

Reviewing files that changed from the base of the PR and between 0ba68ea and 6aae0d4.

📒 Files selected for processing (61)

• .ci/behavior-ownership/partition.v1.json
• .commitrail/INDEX.md
• .commitrail/initiatives/WS-ARCH-001/OVERVIEW.md
• .commitrail/initiatives/WS-ARCH-001/planning/CHUNK_MAP.md
• .commitrail/initiatives/WS-ARCH-001/planning/PLAN.md
• .commitrail/initiatives/WS-ARCH-001/planning/chunks/WS-ARCH-001-04E-canonical-allow-review.md
• .commitrail/initiatives/WS-AUTH-001/OVERVIEW.md
• .commitrail/initiatives/WS-AUTH-001/planning/CHUNK_MAP.md
• .commitrail/initiatives/WS-AUTH-001/planning/PLAN.md
• .commitrail/initiatives/WS-CON-001/OVERVIEW.md
• .commitrail/initiatives/WS-POL-003/OVERVIEW.md
• .commitrail/initiatives/WS-POL-003/planning/CHUNK_MAP.md
• .commitrail/initiatives/WS-POL-003/planning/PLAN.md
• .commitrail/initiatives/WS-REV-001/OVERVIEW.md
• .commitrail/initiatives/WS-REV-001/WS-REV-001-04C.md
• README.md
• backend/app/modules/contributions/api/participation.py
• backend/app/modules/contributions/records/participant.py
• backend/app/modules/contributions/records/repository.py
• backend/app/modules/reviews/acceptance/__init__.py
• backend/app/modules/reviews/acceptance/participant.py
• backend/app/modules/reviews/acceptance/repository.py
• backend/app/modules/reviews/acceptance/schemas.py
• backend/app/modules/reviews/api/acceptance.py
• backend/app/modules/tasks/accepted_effects.py
• backend/app/modules/tasks/api/__init__.py
• backend/app/modules/tasks/api/accepted_effects.py
• backend/app/modules/tasks/repository.py
• backend/scripts/behavior_ownership.py
• backend/scripts/test_lane_catalogue.py
• backend/tests/contributions/participation/support.py
• backend/tests/contributions/participation/test_contracts.py
• backend/tests/contributions/participation/test_postgresql.py
• backend/tests/contributions/participation/test_transactions.py
• backend/tests/reviews/acceptance/participation_support.py
• backend/tests/reviews/acceptance/support.py
• backend/tests/reviews/acceptance/test_contracts.py
• backend/tests/reviews/acceptance/test_participant_contracts.py
• backend/tests/reviews/acceptance/test_participation.py
• backend/tests/reviews/acceptance/test_participation_transactions.py
• backend/tests/tasks/accepted_effects/__init__.py
• backend/tests/tasks/accepted_effects/support.py
• backend/tests/tasks/accepted_effects/test_contracts.py
• backend/tests/tasks/accepted_effects/test_postgresql.py
• backend/tests/tasks/post_submit_routing/test_contracts.py
• backend/tests/test_behavior_ownership.py
• backend/tests/test_ci_lane_catalogue.py
• docs/architecture_data_model.md
• docs/architecture_lifecycle_state_machine.md
• docs/architecture_lockdown.md
• docs/engineering/authorization_activation_custody.md
• docs/glossary.md
• docs/operations_payment_reputation.md
• docs/product_brief.md
• docs/product_first_user_flows.md
• docs/roadmap_status.md
• docs/spec_artifact_storage_service.md
• docs/spec_authorization_service.md
• docs/spec_chunk_4_task_queue_assignment.md
• docs/spec_contribution_compensation.md
• docs/spec_review_lifecycle.md

💤 Files with no reviewable changes (1)

• backend/app/modules/reviews/acceptance/schemas.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The change adds hidden participation that stages or replays FinalAcceptance, TASK terminal effects, and CON submitter outcomes in a caller-owned transaction. It adds strict contracts, source and lineage checks, explicit replay handling, and tests. Routing handlers, AUTH receipt custody, and production activation remain outstanding.

Changes

Shared acceptance participation

Layer / File(s)	Summary
Acceptance API contracts backend/app/modules/reviews/api/acceptance.py, backend/app/modules/reviews/acceptance/schemas.py	Adds strict acceptance input, request, result, facts, conflict, and port contracts in the reviews API. Removes the former acceptance schema module.
CON acceptance-derived replay backend/app/modules/contributions/api/participation.py, backend/app/modules/contributions/records/*, backend/tests/contributions/participation/*	Submitter requests now require a new or replay disposition. The repository inserts new facts only for new and checks exact stored facts for replay.
TASK accepted-effects preparation and application backend/app/modules/tasks/api/*, backend/app/modules/tasks/accepted_effects.py, backend/app/modules/tasks/repository.py, backend/tests/tasks/accepted_effects/*	Adds fenced task and assignment locking, new-or-replay preparation, terminal updates for new acceptance, and exact routing-manifest verification.
FinalAcceptance transaction participant backend/app/modules/reviews/acceptance/*, backend/tests/reviews/acceptance/*	Adds source validation and exact acceptance persistence, then composes TASK effects and CON participation. Tests cover replay, rollback, concurrency, lineage conflicts, and partial effects.
Ownership, validation, and delivery boundaries .ci/behavior-ownership/partition.v1.json, backend/scripts/*, backend/tests/test_behavior_ownership.py, backend/tests/test_ci_lane_catalogue.py, .commitrail/*, README.md, docs/*	Registers the new lifecycle targets and test modules. Plans and documentation describe the hidden participant and retain AUTH receipt, database closure, currentness, audit/outbox, and activation as remaining requirements.

Priority: ⬇️ Low

Estimated code review effort: 4 (Complex) | ~50 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant FinalAcceptanceParticipant
  participant TaskAcceptedEffectsParticipant
  participant FinalAcceptanceRepository
  participant SubmitterParticipation
  Caller->>FinalAcceptanceParticipant: Submit request in caller-owned transaction
  FinalAcceptanceParticipant->>TaskAcceptedEffectsParticipant: Lock task effects and classify disposition
  FinalAcceptanceParticipant->>FinalAcceptanceRepository: Validate source and persist or replay acceptance
  FinalAcceptanceParticipant->>TaskAcceptedEffectsParticipant: Apply task effects
  FinalAcceptanceParticipant->>SubmitterParticipation: Stage contribution and awards using disposition
  FinalAcceptanceParticipant-->>Caller: Return acceptance, task, and submitter facts

Loading

Merge Risk: ⚪ Minimal · up to 6aae0

No actionable change-specific defect remains. The participant is hidden and does not activate acceptance; merge can proceed after the planned checks and required approval.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 6aae0

The new workflow changes persistent task and economic facts, but remains disconnected from production entrypoints. Exact source checks and replay rules limit unintended changes. Production activation still requires authorization, currentness, and complete rollback guarantees that are outside this PR.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The inspected mechanical operation affects a project-scoped task, its exact assignment and latest submission, one acceptance, and related contribution and award facts. No new externally reachable attack scope was demonstrated because production composition remains absent. Future activation would expose security-sensitive task and economic outcomes.

Security Findings and Attack Paths

• inferred — No introduced production attack path is supported by the inspected evidence. Caller-supplied identities reach sensitive database writes only through the hidden participant's lineage checks and injected owner ports. The missing authorization receipt is an explicit activation limitation, not evidence of a currently reachable bypass.

Trust Boundaries and Controls

• observed — TASK checks project, contributor, assignment, latest submission, content identity, and frozen policy under locks. Acceptance replay compares every supplied immutable field across unique identity axes. CON checks stored source lineage and complete frozen award facts; replay cannot create missing economic effects.

Resilience and Maintainability Implications

• observed — The design does not yet claim acceptance-versus-evaluation-supersession safety. The change record identifies an existing CHECKERS reservation path without the TASK lock and requires future TASK-first locking, terminal-task rejection, and source-currentness revalidation before activation.

Hardening Proposals

• proposed — At activation, verify that every initiating caller rolls back after participant failure or cancellation, and prove both evaluation-supersession race orders together with exact authorization custody and shared audit/outbox atomicity. These are future activation proofs, not findings against the hidden participant.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 29.70% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 101 functions across 30 files. (30 skippe…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly summarizes the main change: composing hidden shared acceptance and TASK effects.
Description check	✅ Passed	The description gives a detailed change summary, design, scope, evidence, test delta, reviews, remaining risks, and human merge ownership. It omits or combines some template sections, including altern…

Full details: Docstring Coverage

Explanation

Docstring coverage is 29.70% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 101 functions across 30 files. (30 skipped: 30 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}