Repository navigation
Add post-submit policy approval APIs #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
abiorh-claw
merged 16 commits into
main
from
codex/ws-pol-002-03-post-submit-approval-visibility
Jul 11, 2026
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ae7e0a1
Add post-submit policy approval APIs
Abiorh001 dec79fb
Add WS-POL-002-03 review evidence
Abiorh001 aa3325a
Update WS-POL-002-03 PR state
Abiorh001 8414dbd
Merge branch 'main' into codex/ws-pol-002-03-post-submit-approval-vis…
abiorh-claw 1968096
Rebind WS-POL-002-03 review evidence
Abiorh001 e42b950
Align WS-POL-002-03 review state
Abiorh001 144eba1
Rebind WS-POL-002-03 review evidence
Abiorh001 6966c86
Merge remote-tracking branch 'origin/main' into codex/ws-pol-002-03-p…
Abiorh001 5a04d79
Rebind WS-POL-002-03 evidence after main merge
Abiorh001 9872ff6
Clarify authorization implementation gate
Abiorh001 e3344b0
Keep authorization initiative outside post-submit PR
Abiorh001 82af3ad
Align post-submit activation documentation
Abiorh001 5fc9285
Lock post-submit provenance wording
Abiorh001 77514c2
Preserve post-submit correction provenance
Abiorh001 0e59873
Scope post-submit correction context
Abiorh001 1e20b79
Bind WS-POL-002-03 final review evidence
Abiorh001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
...ost-submit-checker-foundation/reviews/WS-POL-002-03-external-review-response.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # External Review Response: WS-POL-002-03 | ||
|
|
||
| ## Comments Addressed | ||
|
|
||
| - GitHub Actions Agent Gates and Backend both failed at the internal review | ||
| evidence gate on PR head `8414dbdffcbcec108f0e736a06e7bbc750eca18b`. | ||
| The failure was valid: `main` had been merged into the PR branch after the | ||
| original evidence was bound, so the reviewed SHA was stale. | ||
| - Rebound `WS-POL-002-03` internal review evidence and PR trust bundle to the | ||
| merged PR head before this evidence-only repair commit. | ||
| - CodeRabbit found stale/conflicting lifecycle state across `LOOP_STATE.md`, | ||
| `WORK_QUEUE.md`, `REVIEW_LOG.md`, WS-POL-002 status/chunk-map artifacts, and | ||
| product/operator docs. | ||
| - Fixed the valid lifecycle-state comments by representing PR #90 as the current | ||
| `WS-POL-002-03` review chunk, removing duplicate or stale paused rows, and | ||
| marking future WS-POL work as separately gated. | ||
| - Fixed the valid correction-flow comment by stating that correction requests | ||
| block activation, supersede and retain rejected output, requeue regeneration, | ||
| and do not satisfy the approval gate. | ||
| - A later CodeRabbit thread targeted WS-AUTH planning wording that entered PR | ||
| #90 through merge-state reconciliation. Rather than changing the separate | ||
| authorization initiative from this WS-POL chunk, all WS-AUTH initiative-file | ||
| deltas were removed; that worktree remains independent. | ||
| - Internal review then found that destructive correction cleanup could erase | ||
| audit provenance and rerun the same agent input. The repair now retains | ||
| superseded policy rows, supplies bounded exact-context correction feedback, | ||
| rejects unchanged replacements, and distinguishes correction from upstream | ||
| policy supersession. | ||
|
|
||
| ## Comments Deferred | ||
|
|
||
| - None. | ||
|
|
||
| ## Human Decisions Needed | ||
|
|
||
| - None from external review at this point. | ||
|
|
||
| ## Commands Rerun | ||
|
|
||
| ```bash | ||
| gh run view 29157251423 --log-failed | ||
| gh run view 29157251426 --log-failed | ||
| cd backend && .venv/bin/pytest tests/test_projects.py -q -k "post_submit_checker_policy or post_submit_setup_visibility" | ||
| cd backend && .venv/bin/pytest tests/test_alembic.py -q | ||
| cd backend && .venv/bin/pytest tests/test_auth.py -q | ||
| cd backend && .venv/bin/ruff check app tests scripts | ||
| cd backend && .venv/bin/docstr-coverage --config .docstr.yaml | ||
| python3 scripts/check_internal_review_evidence.py | ||
| python3 scripts/check_loop_memory_state.py | ||
| python3 scripts/check_stale_workstream_wording.py | ||
| python3 scripts/check_markdown_links.py | ||
| git diff --check | ||
| ``` | ||
|
|
||
| ## Remaining Risks | ||
|
|
||
| - The current fixes are bound to reviewed non-evidence commit | ||
| `0e59873971db8c2a7d9d6f9f7e725cb902eb888e`. | ||
| - CodeRabbit and GitHub Actions must rerun on the final evidence-only pushed head. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.