Leave the sign-on gate's three head readings as the commands that produced them - #389
Merged
Merged
Conversation
…duced them [#388] `docs/gate-parity.md` opened on three readings taken from the head of the sign-on plugin's default branch, each pasted under the command that produced it: fifteen check-run names at lines 29 to 43, a repeat count at lines 50 to 52, and a job URL at line 95. That head is not this repository's, so it moves whenever that board pushes, and all three had moved. The first pasted fifteen names and the command answers fourteen. Pinned to the commit that wrote it so the reading stays reproducible: git show a5c1bba:docs/gate-parity.md | sed -n '29,43p' | sed 's/^ //' | sort > pasted gh api repos/Flowfin/jellyfin-plugin-sso/commits/main/check-runs --jq '.check_runs[].name' | sort -u > live echo "pasted $(wc -l < pasted) live $(wc -l < live)" pasted 15 live 14 comm -23 pasted live Report any workflow that concluded non-success on the default branch The name that left is the one the sentence under it counted six times, so the second reading went with it. No name appears twice on that commit now: gh api repos/Flowfin/jellyfin-plugin-sso/commits/main/check-runs --jq '.check_runs[].name' | sort | uniq -c | sort -rn | head -3 1 wiki-lint 1 submit-nuget 1 Scorecard analysis The third pasted a job URL from the same head, which names a different run today: gh api repos/Flowfin/jellyfin-plugin-sso/commits/main/check-runs --jq '.check_runs[] | select(.name == "submit-nuget") | .html_url' https://github.com/Flowfin/jellyfin-plugin-sso/actions/runs/34981745754/job/104423522996 Nobody edited those paragraphs. All three landed right on the day: git log -S'6 Report any workflow that concluded non-success' --format='%h %ad %s' --date=short -- docs/gate-parity.md a5c1bba 2026-08-12 Write the parity table against the gate on the sign-on plugin (#134) The repair is the move this file already took eleven lines below the third reading, for its own workflow list: the output is deleted rather than refreshed, the command is left standing alone, and a reading that is still needed is pinned so it stays reproducible. A fresh list is a second thing that goes stale the same way, and against a head this repository does not control it goes stale sooner. The deduplication sentence keeps what it is for, which is a property of the command's input rather than a claim about whichever head answers next, and the reading that showed it is pinned to `a5c1bba` rather than re-pasted. The third reading's stale URL goes and the paragraph says where the run id under it came from, because a run id is permanent and that second command still answers. What it prevents: a reader measuring parity against this document compares the sign-on gate's checks against this repository's, and the list they compare was one the command beside it contradicted. The count sentence was the worse half, because it told a reader what the deduplication is for using a number that is now zero, in a paragraph whose first sentence already says the paste moves. What this does not cover: the parity table's verdict column, which is #377 and is untouched. The workflow-file listing at lines 61 to 85, which is read from a clone of that board rather than from its head and is a different command. And any route that would notice the next time a reading of another board's head moves - nothing here compares a paste against its command on any schedule, and what found these three was a re-run by hand. Closes #388 Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue this belongs to
Closes #388
What changed
docs/gate-parity.mdopened on three readings taken from the head of thesign-on plugin's default branch, each pasted under the command that produced it:
fifteen check-run names, a repeat count over the same list, and a job URL. All
three outputs are deleted and their commands left standing alone, which is the
move this file already took further down for its own workflow list. The one
reading still needed is pinned to the commit that wrote it rather than re-pasted,
and the paragraph carrying the job URL now says where the run id under it came
from.
What failure it prevents
A reader measuring this repository's gate against the sign-on plugin's compares
two lists, and the list they were handed was one the command beside it
contradicted. That head is not this repository's, so it moves whenever that board
pushes and nothing here notices.
The count sentence was the worse half. It told a reader what the deduplication in
the command is for using a number that is now zero, in a paragraph whose own
first sentence already said the paste moves.
This is a correction, and it has already happened rather than being a risk. How
it was found: I re-ran every paste in this tree sitting under a
ghcommand,which is a seam a sweep by
gitcommand alone does not reach.Evidence
Read at the commit being pushed,
55ed63b, against the sign-on plugin's defaultbranch at
dee0b596a9058ecb56e89f009a741fce1f5bb016.The first reading pasted fifteen names and the command answers fourteen. Pinned
to the commit that wrote it, so this reading reproduces after the deletion:
The name that left is the one the sentence under it counted six times, so the
second reading went with it. No name appears twice on that commit now:
The third pasted a job URL from the same head, which names a different run now:
The pinned id it hands on still answers, which is why that command and its output
are kept where the other three outputs go:
All three were right when they landed, and nobody opened those paragraphs since:
The head this change is, in the shape the gate asks for:
The three document checks that read this file, run at this commit:
What this does not cover
waitingrows are,and nothing here reads or moves a verdict.
clone of that board rather than from its head, it is a different command, and
the paragraph under it already hands the reader a derivation for its count.
moves. Nothing here compares a paste against its command on any schedule, and
what found these three was a re-run by hand.
ghcommand has moved. Ire-ran that seam and two further sites came back changed, in
docs/decisions/0303-the-licence-the-core-is-offered-under.mdanddocs/decisions/0113-the-target-triples-the-gate-compiles-for.md. Both are inlanded decision records, where the repair is held by an open rule question, so
neither is touched here; each is written on the issue whose decision governs
it.
src/ortests/is reached by it, so the compile and test legs are unexercised byanything in this diff rather than reported as green by me.
Who has read it
Nobody other than the author has read this change. There is no second reader on
this board tonight, so the evidence above stands in place of one: every number in
it carries the command that produced it, and the two readings that are needed
after the deletion are pinned to fixed commits rather than to a head that moves.