Anchor the parity clone to the commit the table is written against - #391
Merged
Merged
Conversation
docs/gate-parity.md told a reader to clone the sign-on plugin with --depth 1 and pasted the head that landed as the commit the table is measured against. That head belongs to a repository this board does not control and moves when it pushes, so the pair answered fadecd85 rather than 54c5bf4 on 2026-09-17 and the sha under it had stopped reproducing. What that cost is the block below it. That block lists the other repository's workflow files with their triggers, it is run inside the clone, and this file says of it that it is the set which decides parity because it does not move between two readings of one commit. Run against the clone those commands make today it came back with two of its twenty-four rows changed, so a reader following the section in order read one commit's workflow files against a table written against another, with nothing in front of them saying which was wrong. The clone command names the commit now, so the sha is an argument rather than an output and cannot drift. Refreshing it was refused for the reason this file already gives for its other moving readings: a fresh sha goes stale on the same event. Deleting the output, which is this file's other shape, was not available either, because this reading is the reference every other reading in the file is taken at. Closes #390 Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue this belongs to
Closes #390
What changed
docs/gate-parity.mdtells a reader how to get the repository the parity tableis measured against. That instruction cloned
--depth 1and pasted the head itlanded on as the commit the table is written against. It now clones without a
checkout and checks the commit out by name, so the sha is an argument rather
than an output.
Two paragraphs are added under the block saying what the old pair did, what it
cost, and why neither of this file's two existing repair shapes was taken.
What failure it prevents
A reader following the section in order reading one commit's workflow files
against a table written against another, with nothing in front of them saying
which is wrong. It has already happened rather than could:
--depth 1takes thedefault branch head of a repository this board does not control, that head moved,
and no event here records it.
The old pair, run today:
against the
54c5bf468a4f8719309fd59aa7f448ab17bfbbf8the file pastes under it.The block below that pair is run inside the clone, and the file says of it that
it is the set which decides parity because it does not move between two readings
of one commit. From the clone the old pair makes, two of its twenty-four rows
come back changed -
e2e-login.ymlcarriesworkflow_callwhere the paste hasrelease, andwiki-lint.ymlhas gainedgollum.Evidence
Run at
fd53a614d6041fae4a1c7e43b9281d41a7d2e2c4, the commit being pushed.The commands as this change writes them land on the commit the table names:
and the block under them, taken out of the file at the pushed commit and run in
that clone, reproduces the pasted rows byte for byte:
The change is one file and one commit:
Two gate legs that read this file were run here.
doc-paths:and the scan
unicode-guardruns, where 1 is the clean answer:What this does not cover
The block that lists the other repository's workflow files is unchanged, and so
is every other reading in this file. Whether those still reproduce is not
re-asserted here; the readings taken under
ghin this file were read elsewheretoday and this change touches none of them.
The line numbers in this file move by eighteen, so
76,77and100above arewhere the block sits at the pushed commit and not where it sat on
main. Anyreading taken against
mainand quoted afterwards would name the older numbers.Nothing here refuses a future
--depth 1paste. No check in this tree re-runs acommand a document writes down, which
docs/decisions/0269states of itself, sothis repair is carried by the file and by whoever reads it.
The remaining legs of the gate were not run on this machine.
coverage,build,targets,cross-toolchain,test,lint,formatand the rest are therunner's, and this change touches no Rust and no workflow file.
Who has read it
Nobody other than me. There was no second reader available for this change, and
the evidence above stands in place of one.