Read this board's subjects rather than counting them beside the switch - #401
Merged
Merged
Conversation
`.github/workflows/shared-hygiene.yml` calls the shared hygiene check with the subject rule switched off, and the only thing saying why is a count of this board's own commit subjects, taken on 2026-08-23 and never re-taken. Both halves of it are wrong. It said that of the last fifty-two authored subjects not one was in the brackets the fleet rule wants, which was true when written and stopped being true on 2026-09-05, when the first bracketed subject landed. It said the twelve most recent carried no reference at all, and at the commit that wrote the sentence one of those twelve did: the commit itself. The numbers are deleted rather than corrected and the command that answers them takes their place, because no route on this board reads a count in a comment and a corrected number goes stale the same way. What the file now says about the input is that deciding it needs which subject the called workflow reads, which is pinned by hash in another repository and is not read here. The input is unchanged and no job, trigger, permission or pin is touched. Closes #400 Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue this belongs to
Closes #400
What changed
The header of
.github/workflows/shared-hygiene.ymlno longer counts thisboard's commit subjects. The command that answers the count stands where the
numbers were, the correction says what they said and when each stopped being
true, and the paragraph that follows says what deciding the input would take.
The input itself is unchanged, and so is every trigger, permission, job and pin
in the file.
What failure it prevents
The switch
subject_names_issue: falseis an input to a workflow pinned by hashin another repository, and the only thing on this board saying why it is set that
way was that count. A reader deciding whether the rule can be turned on read a
measurement taken on 2026-08-23 and never re-taken, and took this board for one
that never names an issue in a subject.
Both halves were wrong. Thirty-one of the last fifty-two authored subjects are in
exactly the shape the sentence said none of them were:
And the half about the twelve most recent was refuted at the commit that wrote
it, by that commit:
It was found by reading the header of every workflow file on this board against
the tree, after the same defect was repaired in two documents earlier today.
Evidence
The commit being pushed:
Neither claim stands in the present tense any more, and the command that answers
them is in the file:
The input is where it was:
The file still parses:
What this does not cover
another repository and I did not read it, so whether
subject_names_issuejudges a pull request title or a commit subject is not settled here, and the
edited comment says so rather than assuming it. The two populations answer
differently: nine of the last fifty-two merged pull request titles carry a
bracketed reference against thirty-one of the authored subjects.
true. Twenty-one of the last fifty-two authoredsubjects carry no bracketed reference, turning the rule on would judge every
pull request here, and nothing in this change asks for that.
comment, so the next one is refused by nothing and would be found by a reader
again. No check is added, and none is asked for.
calling the shared check beside the local gate are untouched.
Who has read it
Nobody other than me has read this change. The evidence above stands in place of
a second reading rather than beside one.