Say that the pin this gate waits for is here, and that the revisit is untaken - #409
Merged
Merged
Conversation
… untaken .github/lint/lint.sh leaves the `nursery` lint group undenied and gave two reasons. The second was that a toolchain upgrade can redden this gate for an unfinished lint "and the version this repository builds with is not even pinned yet, which is #14", closing with "It is worth revisiting once it is". The version is pinned. rust-toolchain.toml pins 1.98.0 and names clippy among its components, clippy is what this leg runs, and #14 closed as completed. The paragraph now names that file and that component list, says the upgrade it guards against is a commit to it rather than a runner image moving underneath the gate, and says the revisit it asks for is available and has not been taken. Whether `nursery` is denied now is a judgement about how strict this gate is and is deliberately not settled here: taking it inside a correction to a comment would decide it without anybody deciding it. The first half of the reason is unchanged, because it does not depend on the pin. The sentence was written on 2026-08-25 at 07:35 and the pin landed at 17:16 the same day, in a change that had no reason to open this comment, so it held for under ten hours and has been false for the twenty-three days since. It was found by reading it against the other sites in .github/ that name #14: every one of them reads the pin as landed, and this was the only one that did not. It prevents a revisit condition staying invisible after it is met. The file that sets the condition is the file a reader checks it against, so a stale one there holds the question open indefinitely with nothing saying it is answerable. No rule, register entry, denied group or setting of this leg changes. Closes #408 Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue this belongs to
Closes #408
What changed
The paragraph in
.github/lint/lint.shthat explains why thenurserylint groupis not denied now names
rust-toolchain.tomland the component list that putsclippyinside the pin, says that the upgrade it guards against is a commit tothat file rather than a runner image moving underneath the gate, and says that the
revisit it asks for is available and has not been taken. It also says what it
claimed before and how that was found.
Whether
nurseryis denied now is deliberately NOT decided here. That is therevisit itself, it is a judgement about how strict this gate is, and taking it
inside a correction to a comment would settle it without anybody deciding it.
No rule, register entry, denied group, threshold or setting of this leg changes.
Every added line is a comment.
What failure it prevents
A revisit condition staying invisible after it is met. This file is where the
condition is set and is therefore where a reader checks it, so a stale one here
holds the question open indefinitely with nothing saying it has become answerable.
The condition has been met for twenty-three days and the only thing that could
have said so was saying the opposite.
This is a correction and the failure has already happened. What was wrong: the
paragraph said "the version this repository builds with is not even pinned yet,
which is #14" and closed with "It is worth revisiting once it is". How it was
found: by reading it against the other sites under
.github/that name #14, everyone of which reads the pin as landed.
Evidence
Read at
28537c6c5f1d5bda1dc14c8ac2f8d64f3d8e6ef1, which is the base of thisbranch. The head being pushed is
ff09a87.The sentence as it stood.
The pin it says is absent, and that
clippyis inside it.It held for under ten hours.
The order is the lint change first, then the pin, and the change that landed the
pin did not open this comment:
The phrase survives at this head only as a quotation inside the correction, and
nothing at this head asserts it.
That is the one occurrence, it is the sentence reporting what was wrong, and the
negative disclosure is kept rather than deleted so a later reader meets the
correction instead of a paragraph that was always right.
The register fixtures still hold at this head, which is what proves the parser
still reads this file the same way.
The paths this change touches.
The means. The change is prose in the comment header of a shell script, in the
format that file already is. It adds no language, no runtime and no dependency.
What this does not cover
nurseryshould now be denied. That is the revisit, it is ajudgement nobody has taken, and this change writes down that it is available
rather than taking it. The paragraph says so in those words.
restrictiongroup. Its reason does not depend on the pin and is notread or edited here.
lintleg should compare the compiler that ran against the pin..github/toolchain/toolchain.shholds that comparison andbuild.ymlruns it.Whether
lintshould too is a separate question and is not asked here..github/lint/lint.sh. I read the paragraph about thetwo undenied groups. That is a sweep of one paragraph rather than of the file.
shellcheckis not installed on the machine this waswritten on, so
.github/shell-analysis/shell-analysis.shcould NOT be runhere - it refused with
shellcheck: command not found. That leg's verdict onthis change is whatever its run on this pull request reports, and I have not
predicted it. The change adds only comment lines, which is a reason to expect
it to pass and is not a measurement of it.
.github/lint/lint.sh selfteston this machine andnothing else. The rest is what this pull request's own runs report.
Who has read it
Nobody other than the author has read this change. There is no second reader on
this board tonight, and the evidence above stands in place of one rather than the
question being left open.