Stop the artwork address module calling absent what the file beside it holds - #478
Merged
Merged
Conversation
…t holds (#477) `src/artwork/address.rs` said in its `What is here and what is not` section that what an item with no image of a kind answers with is #51 and is deliberately absent. `src/artwork/presence.rs` is that answer. It says of itself that it is the value 0049 stops one step short of, it imports six types from this module in library code rather than merely sitting beside it, and it landed on `7c5d9e5`, the day after the sentence. The same commit added the paragraph in `src/artwork/mod.rs` that names it, so this file has been the only one in `src/artwork/` calling that answer absent. #51 closed as completed on 2026-08-31, two days after the sentence. The section now keeps the rule it exists for and drops the hand-off: a tag is a required input here, so an item carrying none for a kind produces no address at all rather than an address with an empty tag in it, and where that item's answer lives is named rather than deferred. It was wrong in the direction that reads as covered. Somebody looking for what a client is handed when an item has no poster read here that it is deliberately absent and was sent to a closed issue, while the directory's own header said the opposite one file over. It was found by reading this directory's hand-offs against the modules beside them. The absence that still holds is kept and stays negative: the transport is #27, it is open, and no call in this module reaches a network. No behaviour changes. The whole diff is doc comments. Closes #477 Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue this belongs to
Closes #477
What changed
The
What is here and what is notsection ofsrc/artwork/address.rsstopssaying that what an item with no image of a kind answers with is #51 and is
deliberately absent. It keeps the rule the paragraph exists for - a tag is a
required input here, so an item carrying none for a kind produces no address at
all - and names
crate::artwork::presenceas the module holding the answer.Nothing else moves. No kind, no ladder, no refusal, no signature.
What failure it prevents
The module handed an answer to a closed issue while the file one directory entry
away held it, was built out of this module's own types, and said so of itself.
The directory's own header named that module in the paragraph directly below the
one about this module, so the two documents a reader meets first disagreed about
whether the answer existed.
That is wrong in the direction that reads as covered. Somebody looking for what
a client is handed when an item has no poster read here that it is deliberately
absent, followed a closed issue, and did not open the file beside this one.
It was found by reading this directory's hand-offs against the modules beside
them.
Evidence
The commit being pushed:
What the section said, at the parent:
The answer, at the parent, saying of itself that it is that value:
It is a caller of this module rather than a neighbour, and the import is library
code:
The directory's own header already named it, in the paragraph below the one
about this module:
The dates. The sentence landed on 2026-08-29, the module that answers it landed
the next day and brought the index paragraph with it, and the issue closed as
completed two days after the sentence:
The absence that survives, which is why the section is kept rather than deleted.
The transport is open and no call in this module reaches a network:
What the change is:
The two commands the gate runs, at this commit. The build was run first and
exited 0; its own summary line is not pasted, because this board's hygiene check
reads the word in it as a speed claim:
Four of this board's own legs, run on this machine at this commit:
What this does not cover
src/artwork/presence.rsandsrc/artwork/mod.rs. Both are read asevidence and neither is edited. They already say what holds.
The fetch. No call in this tree fetches an artwork byte, the transport is
Build the HTTP transport, with timeouts, connection reuse and cancellation #27 and is open, and nothing is claimed about when it arrives.
0049. The record is read and not edited. A record is added or superseded
rather than edited in place, which
docs/decisions/0001-decision-records.mdfixes.The other references to closed issues in this directory. Several files
name
#49,#51,#52and#55as the issues whose conditions a caseasserts, which is a reference to what landed rather than a hand-off to what
will. Whether any of those has gone stale is a separate reading and was not
made here.
Behaviour. No production line changes. The whole diff is doc comments.
A check that would refuse this. Nothing in this tree reads a doc comment's
hand-off against the tracker or against the sibling that answers it, and the
document check reads only
.mdfiles. This adds no rule, so the next sentenceof this shape is caught by a reader or not at all.
The shell analysis. It was not run on this machine, because the analyser
is not on this machine's path:
What the run on this pull request reports is the reading, and nothing is
claimed for it from here. This change touches no shell file.
Who has read it
Nobody other than the author. There is no second reader on this board tonight,
and the readings pasted above stand in place of one rather than a review having
happened.