Record one response set from a Jellyfin 10.11.11 server, scrubbed to the synthetic values - #504
Closed
iderex wants to merge 1 commit into
Conversation
…the synthetic values (#88) The oldest line the core claims to support gets its recording: the same sixteen calls as tests/recorded/jellyfin-12.0.0/, made by the same recorder in the same order with the same request bodies, against jellyfin/jellyfin:10.11.11 run for the purpose over the same three generated videos mounted read-only, scrubbed by the same rule and landing in the same envelope. RECORDED.md beside the files says so and refers to the 12.0.0 record for what each file shows, so that the two cannot drift. READ CALL FOR CALL AGAINST THE 12.0.0 SET, every status agrees and so does every top-level key of every JSON body. What differs below the top level is what the comparison in #88 and #104 reads, and this change does not pre-empt it: #88 asks for a gate leg that runs the suite against these files so that a dependency on something the newer line offers reddens the pull request that introduced it, and that leg is not here. Twenty distinct identifiers, twelve naming a thing and eight digests; the twelve got one synthetic value each and the eight took the remaining four, the last five sharing the sixteenth, by the rule the 12.0.0 record states. The check that judges these files refused nothing: bash .github/fixture-scrub/fixture-scrub.sh check Every rule above was applied to its subject and refused nothing. Contributes to #88. It gives the leg its fixture set and does not build the leg. Signed-off-by: iderex <30603423+iderex@users.noreply.github.com>
Contributor
Author
|
The two commands before a push, run in the worktree at this head, with the format check beside them: The two byte tests of |
Contributor
Author
|
Closed in favour of #506, stacked on #505: three code spans in |
This was referenced Sep 18, 2026
Closed
iderex
deleted the
record/88-one-response-set-from-a-jellyfin-10-11-server
branch
September 18, 2026 12:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #88. It does not close it: the gate leg that runs the suite against the oldest line's fixtures is what closes that issue, and this gives it the fixture set to run against. It is stacked on #503, the 12.0.0 set, which carries the
-textrule and the byte assertion fortests/recorded/; this adds one directory and nothing else, and its base moves tomainwhen that one lands.What changed
tests/recorded/jellyfin-10.11.11/holds the same sixteen calls as the 12.0.0 set, made by the same recorder in the same order with the same request bodies, against ajellyfin/jellyfin:10.11.11server run for the purpose in a container on this machine over the same three generated videos, mounted read-only. The files are scrubbed by the same rule and sit in the same envelope, andRECORDED.mdbeside them refers to the 12.0.0 record for what each file shows, so the two cannot drift.Read call for call against the 12.0.0 set, every status agrees and so does every top-level key of every JSON body. What differs below the top level is what the comparison reads, and this change does not pre-empt it.
The failure it prevents
The one #88 names: a request to an endpoint the older server does not have, or a response field that arrived in a later version, appearing at sign-in on somebody's real server rather than in the gate. A recording from a real server of the oldest supported line is what that leg compares against, and this is the recording.
Evidence
The scrub check over the tracked subject, run at this head before the commit:
The two commands
CONTRIBUTING.mdnames before a push were run in this worktree and are pasted in the first comment below.What this does not cover
The gate leg itself, the comparison that reads these files, and the rule for a newer endpoint without the fallback from #10, which #88 lists as what it is blocked on. The raw recording never entered any tree.
Nobody other than me has read this change.