Conversation
…ires This branch exists to take one measurement and is not merged. #291 asks which of 0113's triples the target leg can still compile once the manifest carries `rustls` and `rustls-platform-verifier`, and every reading behind that question so far was taken on a contributor's Windows machine or through the C-compiler probe beside the leg, which compiles one translation unit rather than the provider itself. The entry carries no admitting clause because it is not landing here; the clause belongs to the change that adds it for good. Contributes to #291
…again The run on the head before this one says six of the seven triples fail inside `aws-lc-sys`'s build script on `ubuntu-latest`. This commit takes them out of the register so the same leg is read once more against the set that is left, which is the second half of #291's done-condition: green on a tree carrying the dependency rather than green on a tree without it. Contributes to #291 Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
A draft opened to take two measurements, and it is closed rather than merged.
#291 asks which of 0113's triples the target leg can still compile once the
manifest carries the entry 0243 requires. Every cross-compile reading behind that
question was taken either on a contributor's Windows machine, outside this tree,
or through the
cross-toolchainleg, which compiles one translation unit askingfor the C library headers rather than building a provider.
The first reading: the entry, and the register as it stands
Head
3915c8d4d32cb2e3996f142e3bd59987bce4529f,rustls 0.23.45andrustls-platform-verifier 0.7.0in[dependencies]and nothing else, onubuntu-latestwith the toolchainrust-toolchain.tomlpins.The
targetsrun ishttps://github.com/Flowfin/core/actions/runs/35351749365 and it ends
Every failure is
error: failed to run custom build command for aws-lc-sys v0.45.0,and the tool each one stopped at:
The seventh,
x86_64-unknown-linux-gnu, is the only one that reached the end ofthe build. Its
Finishedline is not pasted here, because the words themeasurement gate reads sit inside the profile name cargo prints on it; the run
above is where it is read.
The second reading: the entry, and the register cut to what the first one left
Head
9cdd5389d78e7862296bd39ed8e63e704f9c4cc1, the same manifest with the sixtriples above taken out of
.github/targets/targets. Thetargetsrun ishttps://github.com/Flowfin/core/actions/runs/35352090075 and it ends
So the leg is green on a tree carrying the dependency, which is the half of
#291's done-condition that no reading before this one answered.
What is not read here
Whether a provider other than the one
rustlsresolves by default changes theanswer. This carries
rustlswith its default features, which is the shape 0243decided, and says nothing about a graph built on another provider.
Whether the runner image will answer the same way next month. The verdict is
this image's at this moment, and the
cross-toolchainleg beside it re-takes theneighbouring reading on every run for that reason.
What it is not
It is not a proposal. The branch begins with
probe/for that reason, the entrycarries no admitting clause under 0303, and no part of it is intended to reach
main.Contributes to #291