Move golang.org/x/sys to v0.44.0, so the dependency set carries no open advisory (#175) - #176
Merged
Merged
Conversation
…en advisory golang.org/x/sys v0.34.0 sits in go.sum as an indirect requirement of chromedp, and GO-2026-5024 (CVE-2026-39824) is filed against every release of that module before v0.44.0. The supply-chain analysis reads the requirement set and raised the Vulnerabilities class on it, and a catalogue whose own dependency set carries a known advisory is the wrong posture for a tree that exists to tell servers what to trust. The affected symbol is NewNTUnicodeString under golang.org/x/sys/windows, which nothing in this tree calls; the requirement arrives through chromedp for the keyboard measurement. The bump therefore changes no behaviour here and removes the advisory from the set the analysis reads. The go directive moves from `go 1.25` to `go 1.25.0` in the same change, because `go mod tidy` under the current toolchain rewrites it to the three-part form and refuses to leave the two-part one; restoring the short form and running tidy again reproduces the rewrite. For #175. Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #175, the
VulnerabilitiesIDclass of the supply-chain analysis, which stands at one open alert on this board:Read 2026-09-07. The advisory is filed against
golang.org/x/sysbelow v0.44.0, and this tree requires v0.34.0 indirectly through chromedp:What changes
go get golang.org/x/sys@v0.44.0andgo mod tidy, and nothing else by hand. Two files move, and the OSV index answers differently for the two versions:The affected symbol is
NewNTUnicodeStringundergolang.org/x/sys/windows, which nothing in this tree calls, so the bump changes no behaviour here. What it changes is the requirement set the analysis reads.The go directive moves from
go 1.25togo 1.25.0in the same diff. That is not a choice:go mod tidyunder the current toolchain rewrites the two-part form to the three-part one, and restoringgo 1.25and running tidy again reproduces the rewrite. I tried exactly that before committing.What I ran
Run on Windows against
bf9ba13. The harness did not run, which every gate run says of itself; no leg depends on it.What this does not close by itself
The issue's Done-when is the class at zero open alerts on the Security tab, and that reading is produced by the next Scorecard run, which
.github/workflows/scorecard.ymlruns on push tomainand never on a pull request. So this request does not carry a closing keyword. Once merged, the alert is re-read from the API after that run and pasted onto #175, and the issue closes on that reading and not on this merge.The planning issue for the class on the operations tracker is erawright/operations#2175.