Skip to content

Say what a server writes where the registrator said nothing does (#385) #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iderex merged 2 commits into from
Sep 7, 2026
Merged

Say what a server writes where the registrator said nothing does (#385) #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0027e71
Say what a server writes where the registrator said nothing does (#385)
iderex Sep 7, 2026
0271e8c
Carry the two line numbers the comment repair moved (#385)
iderex Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,14 @@ public void RegisterServices(IServiceCollection serviceCollection, IServerApplic
// PairingStateMachine takes this and an IUserMappingStore and the second had no
// implementation in this assembly. It has one now and both are registered below.
//
// What is unchanged is that nothing on a server writes a record, because nothing joins an
// enrolment to the state machine, which is issue #350. So the read above answers an empty
// list on every server, which is stated at the action rather than left for a reader to
// infer.
// THIS COMMENT SAID NOTHING ON A SERVER WRITES A RECORD AND THAT THE READ ABOVE ANSWERS
// AN EMPTY LIST ON EVERY SERVER, because nothing joined an enrolment to the state
// machine. Enrolment.Open applies LocalEvent.WindowOpened through the state machine and
// the administrative plane calls it, so a window an administrator opens is a record in
// PairingState.Offered and the read answers with it.
//
// What is unchanged is that no record reaches PairingState.Active, because the ceremony
// that would take it there is issue #19 and nothing derives a long term key pair yet.
serviceCollection.AddSingleton<IPairingRecordStore>(services =>
new FilePairingRecordStore(
RecordStorePath.FileFor(services.GetRequiredService<IApplicationPaths>())));
Expand Down
4 changes: 2 additions & 2 deletions docs/logging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@ writes is under the reading rather than counted here.
origin/master:Jellyfin.Plugin.ServerPairing/Mapping/UserMappings.cs:38: private readonly ILogger<UserMappings> _log;
origin/master:Jellyfin.Plugin.ServerPairing/Mapping/UserMappings.cs:54: public UserMappings(IUserMappingStore mappings, PairingStateMachine pairings, ILogger<UserMappings> log)
origin/master:Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs:130: services.GetRequiredService<ILogger<FilePairingKeyStore>>()));
origin/master:Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs:220: services.GetRequiredService<ILogger<HeldAboutUser>>()));
origin/master:Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs:239: services.GetRequiredService<ILogger<UserMappings>>()));
origin/master:Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs:224: services.GetRequiredService<ILogger<HeldAboutUser>>()));
origin/master:Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs:243: services.GetRequiredService<ILogger<UserMappings>>()));

THIS BLOCK WENT STALE TWICE AND NO RUN ON THIS REPOSITORY SAW EITHER TIME. It
pasted two types, then four, then five, and the command returns 7 that hold a logger; the registration line
Expand Down
Loading