Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds a static theme and CSS for the month calendar, fixes inline date-picker template and theme binding, updates copyright years, adds a test AppShellConfiguratorImpl (and excludes it from the demo JAR), and introduces vaadin-month-calendar.css. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/main/resources/META-INF/frontend/fc-inline-date-picker/fc-inline-date-picker.js`:
- Around line 88-90: In the render template the opening tag <fc-month-calendar
...> is closed with the wrong tag </fc-year-month-field>, breaking DOM
rendering; locate the template (render method) where fc-month-calendar is used
with .month="${this.displayDate}" and `@date-selected`="${this.__onDateSelected}"
and replace the mismatched closing tag </fc-year-month-field> with the correct
closing tag </fc-month-calendar> so the element pair is consistent (also verify
.showWeekNumbers binding remains on the fc-month-calendar element).
In
`@src/main/resources/META-INF/frontend/fc-month-calendar/month-calendar-mixin.js`:
- Around line 120-123: The static theme="fc-month-calendar" is being overridden
by theme$="[[theme]]" when the binding evaluates (so an empty theme clears
required base class); replace the two separate attributes with a single compound
binding that preserves the base theme and appends any inherited value (e.g.
remove theme="fc-month-calendar" and change theme$ usage to a compound binding
such as theme$="fc-month-calendar [[theme]]" or use a computed binding like
theme$="[[computeTheme(theme)]]" with a computeTheme(theme) helper that returns
"fc-month-calendar" + (theme ? " " + theme : "") to ensure the base class always
remains present).
In
`@src/main/resources/META-INF/frontend/fc-month-calendar/vaadin-month-calendar.css`:
- Around line 30-31: Replace the chained simple :not() pseudo-classes with a
single complex :not() containing the three exclusions to satisfy
selector-not-notation: "complex"; specifically update the selector that targets
[part~='date'] (the rule using :not(:empty), :not([part~='disabled']),
:not([part~='selected']) on hover::before) to use one :not(...) that lists
:empty, [part~='disabled'], and [part~='selected'] so stylelint no longer flags
the rule.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
pom.xmlsrc/main/java/com/flowingcode/addons/ycalendar/MonthCalendar.javasrc/main/resources/META-INF/frontend/fc-inline-date-picker/fc-inline-date-picker.jssrc/main/resources/META-INF/frontend/fc-month-calendar/month-calendar-mixin.jssrc/main/resources/META-INF/frontend/fc-month-calendar/vaadin-month-calendar.csssrc/test/java/com/flowingcode/vaadin/addons/AppShellConfiguratorImpl.javasrc/test/resources/META-INF/frontend/styles/test_year-month-calendar.css
src/main/resources/META-INF/frontend/fc-inline-date-picker/fc-inline-date-picker.js
Outdated
Show resolved
Hide resolved
src/main/resources/META-INF/frontend/fc-month-calendar/month-calendar-mixin.js
Outdated
Show resolved
Hide resolved
src/main/resources/META-INF/frontend/fc-month-calendar/vaadin-month-calendar.css
Show resolved
Hide resolved
javier-godoy
force-pushed
the
vaadin-25-styles
branch
from
ed6e83c to
a34dcdd
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/main/resources/META-INF/frontend/fc-month-calendar/month-calendar-mixin.js (1)
120-122: Redundant staticthemeattribute.The compound binding
theme$="fc-month-calendar [[theme]]"on line 120 already includes the base theme. The statictheme="fc-month-calendar"on line 122 is redundant since Polymer's attribute binding (theme$=) will override the static attribute when evaluated.♻️ Proposed cleanup
theme$="fc-month-calendar [[theme]]" on-key-down="_onKeyDown" - theme="fc-month-calendar" >🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/resources/META-INF/frontend/fc-month-calendar/month-calendar-mixin.js` around lines 120 - 122, Remove the redundant static attribute by deleting theme="fc-month-calendar" from the element so the compound binding theme$="fc-month-calendar [[theme]]" is the single source of truth; update any tests or usages that might check for the static attribute and ensure the component continues to rely on the theme$ binding (refer to the theme$="fc-month-calendar [[theme]]" binding and the on-key-down handler _onKeyDown in month-calendar-mixin.js to locate the element).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@src/main/resources/META-INF/frontend/fc-month-calendar/month-calendar-mixin.js`:
- Around line 120-122: Remove the redundant static attribute by deleting
theme="fc-month-calendar" from the element so the compound binding
theme$="fc-month-calendar [[theme]]" is the single source of truth; update any
tests or usages that might check for the static attribute and ensure the
component continues to rely on the theme$ binding (refer to the
theme$="fc-month-calendar [[theme]]" binding and the on-key-down handler
_onKeyDown in month-calendar-mixin.js to locate the element).
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/main/java/com/flowingcode/addons/ycalendar/MonthCalendar.javasrc/main/resources/META-INF/frontend/fc-inline-date-picker/fc-inline-date-picker.jssrc/main/resources/META-INF/frontend/fc-month-calendar/month-calendar-mixin.jssrc/main/resources/META-INF/frontend/fc-month-calendar/vaadin-month-calendar.csssrc/test/resources/META-INF/frontend/styles/test_year-month-calendar.css
🚧 Files skipped from review as they are similar to previous changes (1)
- src/main/java/com/flowingcode/addons/ycalendar/MonthCalendar.java
javier-godoy
force-pushed
the
vaadin-25-styles
branch
from
a34dcdd to
12b94ee
Compare
javier-godoy
force-pushed
the
vaadin-25-styles
branch
from
12b94ee to
ded8ac4
Compare
|
paodb
approved these changes
Mar 5, 2026
github-project-automation
bot
moved this from To Do
to Pending release
in Flowing Code Addons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores