test: add component tests for create-form validation and unlock-chart SVG render - #712
Open
simeontech wants to merge 1 commit into
Open
test: add component tests for create-form validation and unlock-chart SVG render#712simeontech wants to merge 1 commit into
simeontech wants to merge 1 commit into
Conversation
… SVG render Closes FlowwStar#653 — adds __tests__/components/create-form.test.tsx covering: - required fields empty shows recipient + amount errors - invalid recipient address shows address-format error - cliff amount > total amount shows cliff-exceeds-total error Closes FlowwStar#654 — adds __tests__/components/unlock-chart-render.test.tsx covering: - no-cliff stream: SVG renders, unlock path present, no cliff line/legend - cliff stream: SVG renders, dashed cliff indicator line and Cliff legend present All 11 tests pass.
|
@simeontech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds component tests for two open issues, both isolated from e2e coverage.
#653 — Component tests for
create-form.tsxclient-side validationFile:
__tests__/components/create-form.test.tsxTests the
validate()logic insideCreateFormin full isolation using React Testing Library. All heavy dependencies (hooks, contract lib, Next.js navigation, child components) are mocked.invalidAddressFormat+invalidAmounterrors on submitinvalidAddressFormaterror; no amount errorcliffExceedsTotalerror when cliffAmount > amount#654 — Component tests for full SVG render of
unlock-chart.tsxFile:
__tests__/components/unlock-chart-render.test.tsxRenders the full
UnlockChartcomponent with both fixture types and asserts the expected SVG structure. Complements the already-mergedtoX()/toY()unit tests.role="img"element renders<path stroke-width="2">present<line stroke-dasharray="4 3">queryByText('Cliff')returns nullrole="img"element renders<path stroke-width="2">present<line stroke-dasharray="4 3">presentgetAllByText('Cliff')returns resultsTest results
Closes #653
Closes #654