revert(incidents): remove custom fields from OSS#95
Merged
Conversation
Reverts 090b241 ([OPE-109] Custom fields on incidents (#81)). Custom field definitions are a Pro-tier feature and should not ship in the OSS build. Conflicts resolved by keeping the OPE-112 additions (ResolvedSince filter, GetBySlackMessageTS) and the OPE-159/160 properties panel redesign while stripping only the custom field code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
regen-pro, not the OSS buildResolvedSincefilter,GetBySlackMessageTS) and the OPE-159/160 properties panel redesigncustom_fieldsJSONB column onincidentsis retained (it predates OPE-109 — migration 000002) as are allCustomFieldsmodel referencesWhat's removed
custom_field_definitionstable, model, and migration (000039)CustomFieldRepositoryfrontend/src/api/customFields.tsWhat's preserved
incidents.custom_fieldsJSONB column and model field (pre-existing)ResolvedSincefilter andGetBySlackMessageTSonIncidentRepositoryTest plan