[OPE-169] Fix Slack manifest: remove invalid user scopes, add app_mentions:read and reaction_added#98
Closed
singret wants to merge 1 commit into
Closed
[OPE-169] Fix Slack manifest: remove invalid user scopes, add app_mentions:read and reaction_added#98singret wants to merge 1 commit into
singret wants to merge 1 commit into
Conversation
…sync Three fixes to make Slack event delivery work correctly: - Remove invalid user OAuth scopes (openid/email/profile are for Slack Login / OpenID Connect, not bot apps; their presence breaks manifest import in many workspaces) - Add app_mentions:read scope and app_mention bot event so @regen mentions are delivered to the Socket Mode handler - Add reactions:read scope and reaction_added bot event so emoji reactions on the incident card (✅ ack, 🔴 resolve) trigger the existing reaction handler - Add users:read.email scope used by the JIT Slack→Regen account linker The handler code for all three event types already exists in slack_event_handler.go — missing scopes were silently blocking delivery. Closes OPE-169
Contributor
Author
|
Superseded by #101 (OPE-173) which includes all scope fixes in the UI-generated manifest. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes to
slack-app-manifest.yamlthat were silently blocking Slack event delivery. The handler code for all events already existed — the manifest was the only missing piece.openid,email,profile) — these are Slack Login / OpenID Connect scopes; having them in a pure bot app's manifest breaks installation in many workspacesapp_mentions:read+app_mentionevent — required for the existinghandleAppMentionhandler to receive@regenmentions; Slack silently drops events for undeclared scopesreactions:read+reaction_addedevent — required for the existinghandleReactionAddedhandler that maps ✅ → Acknowledged and 🔴 → Resolved; same silent-drop behaviourusers:read.email— used by the JIT Slack→Regen account linker inresolveSlackUserToInternalAfter this fix
Reinstalling the app with the updated manifest will enable:
@regen summarise this incident→ AI response in thread + timeline entryTest plan
@regenmention in an incident channel → bot replies in threadCloses OPE-169