Skip to content

feat: add custom_config label to indicate which options where customized in config context #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koalajoe23 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add custom_config label to indicate which options where customized in config context #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion netbox_prometheus_sd/api/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,11 @@ def extract_custom_fields(obj, labels: LabelDict):


def extract_prometheus_sd_config(obj, labels):
prometheus_sd_config = getattr(obj, "_injected_prometheus_sd_config", {})
prometheus_sd_config = getattr(obj, "_injected_prometheus_sd_config", None)
if not prometheus_sd_config:
return

labels["__meta_netbox_custom_config"] = ",".join(prometheus_sd_config.keys())

metrics_path = prometheus_sd_config.get("metrics_path", None)
if metrics_path and isinstance(metrics_path, str):
Expand Down
13 changes: 13 additions & 0 deletions netbox_prometheus_sd/tests/test_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from itertools import permutations

from django.test import TestCase
from ..api.serializers import (
PrometheusDeviceSerializer,
Expand Down Expand Up @@ -61,6 +63,17 @@ def test_vm_full_to_target(self):
utils.dictContainsSubset({"__scheme__": "https"}, data_list[0]["labels"])
)
self.assertEqual(data_list[0]["targets"], ["vm-full-01.example.com:4242"])
self.assertTrue(
any(
utils.dictContainsSubset(
{
"__meta_netbox_custom_config": ",".join(p),
},
data_list[0]["labels"],
)
for p in permutations(['metrics_path', 'port', 'scheme'])
)
)

self.assertEqual(data_list[1]["targets"], ["vm-full-01.example.com:4243"])
for data in data_list:
Expand Down