Skip to content

fix: related query set fixes #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xoudini wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: related query set fixes #255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
841e105
fix: annotate config context data on device/vm query sets
xoudini Mar 24, 2026
0d67081
fix: use select_related for fk relations
xoudini Mar 24, 2026
291aa01
fix: add missing related relations
xoudini Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 45 additions & 25 deletions netbox_prometheus_sd/api/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ class NetboxPrometheusSDModelViewSet(CustomFieldsMixin, ListModelMixin, BaseView


class ServiceViewSet(NetboxPrometheusSDModelViewSet):
queryset = Service.objects.prefetch_related(
queryset = Service.objects.select_related(
"device",
"virtual_machine",
).prefetch_related(
"ipaddresses",
"tags",
)
Expand All @@ -50,44 +51,63 @@ class VirtualMachineViewSet(NetboxPrometheusSDModelViewSet):
cluster_scope = "cluster__scope"
else:
cluster_scope = "cluster__site"
queryset = VirtualMachine.objects.prefetch_related(
cluster_scope,
"role",
"tenant",
"platform",
"primary_ip4",
"primary_ip6",
"tags",
"services",
"contacts",
queryset = (
VirtualMachine.objects.select_related(
"role",
"tenant__group",
"platform",
"primary_ip4",
"primary_ip6",
)
.prefetch_related(
cluster_scope,
"cluster__group",
"cluster__type",
"tags",
Comment on lines +62 to +66
"services",
"contacts__contact",
"contacts__role",
)
.annotate_config_context_data()
)
filterset_class = VirtualMachineFilterSet
serializer_class = PrometheusVirtualMachineSerializer
pagination_class = None


class DeviceViewSet(NetboxPrometheusSDModelViewSet):
queryset = Device.objects.prefetch_related(
"device_type__manufacturer",
"role" if hasattr(Device, "role") else "device_role",
"tenant",
"platform",
"site",
"location",
"rack",
"parent_bay",
"virtual_chassis__master",
"primary_ip4__nat_outside",
"primary_ip6__nat_outside",
"tags",
queryset = (
Device.objects.select_related(
"device_type__manufacturer",
"role" if hasattr(Device, "role") else "device_role",
"tenant__group",
"platform",
"site",
"location",
"rack",
"parent_bay",
"virtual_chassis__master",
"oob_ip",
)
.prefetch_related(
"primary_ip4__nat_outside",
"primary_ip6__nat_outside",
Comment on lines +91 to +94
"tags",
"services",
"contacts__contact",
"contacts__role",
)
.annotate_config_context_data()
)
filterset_class = DeviceFilterSet
serializer_class = PrometheusDeviceSerializer
pagination_class = None


class IPAddressViewSet(NetboxPrometheusSDModelViewSet):
queryset = IPAddress.objects.prefetch_related("tenant", "tags")
queryset = IPAddress.objects.select_related("tenant__group").prefetch_related(
"tags"
)
serializer_class = PrometheusIPAddressSerializer
filterset_class = IPAddressFilterSet
pagination_class = None
Loading