Repository navigation
feat(warp): register the EGC MCP servers in ~/.warp/.mcp.json (#1678) - #1963
Merged
Merged
Conversation
Warp reads MCP servers from the mcpServers object of ~/.warp/.mcp.json, its global file, and starts those servers itself; the files of other tools it also reads (Claude Code's ~/.claude.json, a project's .mcp.json, Codex's config.toml) only spawn once the person enables them, and the project-scope .warp/.mcp.json is the project's own (docs.warp.dev/agents/capabilities/mcp, read on 2026-10-17). egc init now registers egc-guardian and egc-memory in the global file, merged so the person's own servers stay, gated on ~/.warp, the Linux config directory ~/.config/warp-terminal or warp-terminal on PATH. Tests: the target, its gate on the two directories and on the binary, the file it writes, and a pre-existing server kept with its working_directory and an idempotent second run. Signed-off-by: Felipe Marzochi <fmarzochi@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1678: Warp gets the EGC MCP servers the memory rule points at.
What changes
egc initregistersegc-guardianandegc-memoryunder the standardmcpServersobject of~/.warp/.mcp.json, Warp's global file, whose servers Warp starts itself; merged so the person's own servers stay. Gated on~/.warp, the Linux config directory~/.config/warp-terminalorwarp-terminalon PATH.Warp also reads the files of other tools (Claude Code's
~/.claude.json, a project's.mcp.json, Codex'sconfig.toml), but only spawns those once the person enables it, so the global file is where the servers run without a click. The project-scope.warp/.mcp.jsonis the project's own and is not touched.Source: Warp MCP, read on 2026-10-17.
Verification
tests/lib/mcp-register.test.js134/134 on the branch rebased over main c80350e (Junie and Copilot CLI included), two new cases: the target with its gate (the two directories and the binary) and the file it writes; a pre-existing server kept with itsworking_directoryand an idempotent second run. Both fail onmain.tests/spec/integration-tiers.test.js9/9 with the Warp row updated.npm run preflight: no new findings. Local Sonar gate: 0 new findings.Summary by cubic
egc initnow registersegc-guardianandegc-memoryin~/.warp/.mcp.json, Warp's global file, whose servers Warp starts itself, so they run without the person enabling them.~/.warp,~/.config/warp-terminal, orwarp-terminalon PATH, so a machine without Warp gets nothing written..warp/.mcp.jsonis the project's own and is not touched.Written for commit 67c8624. Summary will update on new commits.