Update dependencies & remove warnings - cargo 1.92.0; added CI build & test#19
Open
etjones wants to merge 6 commits intoFormlabs:masterfrom
Open
Update dependencies & remove warnings - cargo 1.92.0; added CI build & test#19etjones wants to merge 6 commits intoFormlabs:masterfrom
etjones wants to merge 6 commits intoFormlabs:masterfrom
Conversation
- Add #![allow(dead_code)] at module level for AST struct fields (these are meant for library consumers) - Fix lifetime elision warnings by adding explicit '_ annotations to IResult type signatures throughout parse.rs - Update alias macro to handle lifetime and non-lifetime cases separately - Fix SimpleId::parse, Expression::parse, and SimpleExpression::parse to use explicit lifetime annotations
- Update nom dependency in express/Cargo.toml and step/Cargo.toml - Fix fold_many0/fold_many1 API changes: init parameter changed from value to closure in nom 7 - binary_literal: 0 -> || 0 - encoded_string_literal: String::new() -> String::new - simple_string_literal: String::new() -> String::new All 49 tests pass.
- Update nalgebra-glm in gui/Cargo.toml, nurbs/Cargo.toml, triangulate/Cargo.toml - This also upgrades nalgebra from 0.27.1 to 0.34.1 - Resolves the future-incompatibility warning about trailing semicolons in macros No code changes required - the API is backwards compatible for our usage. All 49 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No feature changes, but updates dependencies & removes compile warnings for cargo 1.92.0, late 2025
fn to_type(&'a self, type_map: &mut TypeMap<'a>) -> Type {express/src/parse.rs; unused fields are meant for library consumers, so we want to keep them present even if they're not yet used.Locally developed on a MacOS 15.6.1 system.