Skip to content

Harden backup restore settings - #650

Open
Jacksper13 wants to merge 2 commits into
dev-v2.4.0from
backup-restore-settings-hardening
Open

Harden backup restore settings#650
Jacksper13 wants to merge 2 commits into
dev-v2.4.0from
backup-restore-settings-hardening

Conversation

@Jacksper13

Copy link
Copy Markdown
Collaborator

Summary

  • ignore restored wallet identity metadata that must be derived from the restored secret
  • persist freshly derived XFP/XPUB after backup settings are restored
  • add unit coverage for backup restore settings filtering

Validation

  • python -m py_compile ports\stm32\boards\Passport\modules\tasks\restore_backup_task.py ports\stm32\boards\Passport\modules\tests\test_unit.py ports\stm32\boards\Passport\modules\tests\unit\restore_backup.py
  • git diff --check --cached
  • host-side stubbed regression for restore_settings_from_backup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant