Skip to content

Show amounts for OP_RETURN outputs - #653

Open
Jacksper13 wants to merge 1 commit into
dev-v2.4.0from
show-op-return-output-amount
Open

Show amounts for OP_RETURN outputs#653
Jacksper13 wants to merge 1 commit into
dev-v2.4.0from
show-op-return-output-amount

Conversation

@Jacksper13

@Jacksper13 Jacksper13 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • show the formatted output amount alongside every OP_RETURN message during transaction review
  • preserve the existing OP_RETURN message rendering
  • add simulator regression coverage for zero-value and nonzero-value OP_RETURN outputs

Root cause

render_output() calculated the output value before classifying the destination, but its OP_RETURN branch returned early without including that value in the trusted-display text.

Impact

Users can now review the full economic value of an OP_RETURN output before signing. This changes display formatting only; PSBT parsing, fee calculation, and signing behavior are unchanged.

Validation

  • python -m py_compile for the changed Python files
  • python -m pycodestyle for the changed Python files
  • host execution of the OP_RETURN renderer regression script
  • git diff --check
  • GitHub Actions firmware, bootloader, simulator, tools, Python, Rust, and REUSE checks

@Jacksper13
Jacksper13 marked this pull request as ready for review July 23, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant