Validate legacy settings before flash writes - #660
Draft
Jacksper13 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert falsewith an explicitValueErrorBackground
The legacy internal-flash settings backend attempted to reject JSON larger than its 8,160-byte data area with
assert false. Because Python boolean literals are capitalized, that path raisedNameError. It also selected a flash slot before checking the serialized size, allowing an oversized save attempt to perform flash management before failing.This backend is retained for the Passport Founders Edition v1-to-v2 settings migration; current user settings use the external settings backend.
Validation
pycodestyleon the changed Python filesgit diff --check