Avoid displaying unverified PSBT fees - #662
Open
Jacksper13 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
witness_utxoagainst the hash-verified previous transaction when both PSBT fields are presentImpact
Ordinary single-wallet SegWit transactions continue to display their network fee. Witness-only amounts for inputs Passport will sign retain the existing numeric display because the signature commits to that input amount and the history cache detects changed amounts across signing attempts.
Collaborative transactions whose external input amounts cannot be independently checked now identify the fee as unverified instead of displaying an attacker-controlled value.
Testing
python -m py_compileon changed Python filespython -m pycodestyleon changed Python filespython -m reuse lint-file ports/stm32/boards/Passport/modules/tests/unit/psbt_fee.pygit diff --checkThe native Unix simulator build was not available locally; GitHub CI provides the firmware and simulator build validation.