Conversation
Fix edge case of charge not stopping if charge session runs since the night before
As fiat system only supports schedules at 5 minutes interval, rounding to the next five minutes improves probability of the command be successful the first time
Great catch!
Instead playing with Time objects and edge case, simply parse defined schedule as string and make sure it's consistent
…nsure proper API acceptance
… ensure proper time rounding to avoid API errors
…erence before update schedule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance charge schedule management by refining time handling, ensuring proper API acceptance, and avoiding unnecessary updates. Address edge cases related to charge sessions spanning multiple days and improve error handling in the Fiat vehicle API. Clarify conditions and streamline code for better readability and maintainability.