feat(caching): retain validator entries past expiry for conditional revalidation (v2.1.0) - #1
Merged
Merged
Conversation
…evalidation (v2.1.0) Entries with an ETag or Last-Modified validator were physically evicted from the store exactly when their freshness lifetime (plus stale windows) elapsed, so CachingMiddleware could never send If-None-Match / If-Modified-Since for them — every expiry degraded to a full refetch. This is the root cause behind the Demo 2 workaround in 4c599ee. - Add CacheOptions.RevalidationGraceSeconds (default 300, 0 = previous behavior): extra store retention applied only to entries carrying a validator, in both MemoryCacheStore and DistributedCacheStore. - New CacheOptions-taking constructors on both stores; the existing single-argument constructors remain and use defaults. - Wire the option through DI as a structural option (read at registration time, like MaxCacheSize). - Add real-clock regression tests: existing revalidation tests advance FakeTimeProvider while IMemoryCache evicts on the system clock, so physical eviction never fired in tests and the bug went unnoticed. RealClockRevalidationTests would have caught it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entries with an ETag or Last-Modified validator were physically evicted from the store exactly when their freshness lifetime (plus stale windows) elapsed, so CachingMiddleware could never send If-None-Match / If-Modified-Since for them — every expiry degraded to a full refetch. This is the root cause behind the Demo 2 workaround in 4c599ee.