Adjustable Hood Subsystem#6
Open
nirmalkozak wants to merge 5 commits intomainfrom
Open
Conversation
legoguy1000
requested changes
Mar 24, 2026
Member
legoguy1000
left a comment
legoguy1000
left a comment
There was a problem hiding this comment.
Since this is a prototype, for initial testing let's assume we won't be PID tuning this thing. So we need super basic control to manually move the hood and hold in place.
legoguy1000
reviewed
Mar 24, 2026
| } | ||
|
|
||
| public void setTargetAngle(Angle setAngle) { | ||
| io.setTargetAngle(setAngle); |
Member
There was a problem hiding this comment.
Set limits here so the hood doesn't exceed the maximum angle, nor goes below 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3