Skip to content

fix(ui): thread dithered foreground through textStyleWithForeground #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Belphemur wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): thread dithered foreground through textStyleWithForeground #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions libs/ui/FreeInkUI/src/FreeInkUI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,6 +889,14 @@ TextStyle textStyleWithForeground(TextStyle text, Paint foreground) {
if (foreground.kind == PaintKind::Solid) {
text.color = foreground.color;
text.inverted = foreground.color == Color::White;
} else if (foreground.kind == PaintKind::Dither) {
// A dithered foreground (e.g. a disabled list row's dither(LightGray))
// must reach the renderer's dithered text path. Without this, the color
// stays at its default Black and the rasterizer takes the solid-black
// path, so a disabled row renders indistinguishable from an enabled one
// even though its resolved style carried a gray foreground.
text.color = foreground.color;
text.inverted = false;
}
return text;
}
Expand Down