Get libxenon to compile without errors with -Wall -Werror#68
Open
mitchellwaite wants to merge 10 commits intoFree60Project:masterfrom
Open
Get libxenon to compile without errors with -Wall -Werror#68mitchellwaite wants to merge 10 commits intoFree60Project:masterfrom
-Wall -Werror#68mitchellwaite wants to merge 10 commits intoFree60Project:masterfrom
Conversation
these files in particular throw a lot of warnings, can disable them in the file and enable -Werror for everything else globally
- Unused variables - integer to pointer cast - signed to unsigned without cast
disable -Wformat-overflow in c_except.c due to how the string is built... needs to be reworked so as to not throw *multiple compiler errors*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After I was bitten by implicit function definitions, I set out to see what it would take to get libxenon to compile with
-Wall -Werror. Where practical, I've done so by making the following changes:%r0to0in startup and cache asm files, as per proper PPC assembly convention. They assemble to the same result.In some files, GCC pragmas have been added to ignore certain errors specifically for those files. These files can be addressed in separate changes. I can open issues for this.
elf.c(this one had a lot)iso9660.cc_except.cehci.cdebug.c(though ignoring -Wframe-address might be a requirement)With these changes I can build both libxenon and XeLL with
-Wall -Werrorand produce a binary that is apparently fully functional on the FFFFalcon