fix: resolve SQLite paths relative to config file directory#62
Merged
Conversation
Member
Author
|
LGTM - Good fix for SQLite relative path resolution. resolveSQLitePaths() properly converts relative paths to absolute based on config file location. |
When using relative SQLite database_path in config JSON, paths were resolved relative to the server's working directory (/tmp) instead of the config file location. This caused "database connection not found" errors when the server ran from a different directory than where the config file lived. Now calls resolveSQLitePaths() after JSON unmarshal to convert relative paths to absolute paths based on the config file's directory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
linhdmn
force-pushed
the
worktree-fix+sqlite-path-resolution
branch
from
21cf8ab to
6676da5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
database_pathrelative path resolution to be relative to the config file location, not the server's working directoryRoot Cause
When the MCP server runs from
/tmp(or any directory different from the config file location), relative SQLite paths like./test.dbwere being resolved from/tmpinstead of from the config file's directory.Test plan
go build ./...passesgolangci-lint runpasses🤖 Generated with Claude Code