Skip to content

fix: use sanitizeStringLiteral for TimescaleDB information schema columns #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linhdmn merged 1 commit into from
Apr 19, 2026
Merged

fix: use sanitizeStringLiteral for TimescaleDB information schema columns #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions pkg/db/timescale/hypertable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func sanitizeIdentifier(identifier string) string {
return "\"" + strings.ReplaceAll(identifier, "\"", "\"\"") + "\""
}

// sanitizeStringLiteral escapes a string literal by replacing ' with ''
// sanitizeStringLiteral escapes a string literal by replacing ' with ”
func sanitizeStringLiteral(s string) string {
return strings.ReplaceAll(s, "'", "''")
}
Expand Down Expand Up @@ -175,8 +175,8 @@ func (t *DB) ListHypertables(ctx context.Context) ([]Hypertable, error) {

// Check if compression is enabled
compQuery := fmt.Sprintf(
"SELECT count(*) > 0 as is_compressed FROM timescaledb_information.compression_settings WHERE hypertable_name = %s",
sanitizeIdentifier(ht.TableName),
"SELECT count(*) > 0 as is_compressed FROM timescaledb_information.compression_settings WHERE hypertable_name = '%s'",
sanitizeStringLiteral(ht.TableName),
)
compResult, err := t.ExecuteSQLWithoutParams(ctx, compQuery)
if err == nil {
Expand All @@ -189,8 +189,8 @@ func (t *DB) ListHypertables(ctx context.Context) ([]Hypertable, error) {

// Check if retention policy is enabled
retQuery := fmt.Sprintf(
"SELECT count(*) > 0 as has_retention FROM timescaledb_information.jobs WHERE hypertable_name = %s AND proc_name = 'policy_retention'",
sanitizeIdentifier(ht.TableName),
"SELECT count(*) > 0 as has_retention FROM timescaledb_information.jobs WHERE hypertable_name = '%s' AND proc_name = 'policy_retention'",
sanitizeStringLiteral(ht.TableName),
)
retResult, err := t.ExecuteSQLWithoutParams(ctx, retQuery)
if err == nil {
Expand Down Expand Up @@ -224,9 +224,9 @@ func (t *DB) GetHypertable(ctx context.Context, tableName string) (*Hypertable,
) as space_column
FROM _timescaledb_catalog.hypertable h
JOIN _timescaledb_catalog.dimension d ON h.id = d.hypertable_id
WHERE h.table_name = %s
WHERE h.table_name = '%s'
GROUP BY h.id, h.table_name, h.schema_name
`, sanitizeIdentifier(tableName))
`, sanitizeStringLiteral(tableName))

result, err := t.ExecuteSQLWithoutParams(ctx, query)
if err != nil {
Expand Down Expand Up @@ -318,9 +318,9 @@ func (t *DB) CheckIfHypertable(ctx context.Context, tableName string) (bool, err
SELECT EXISTS (
SELECT 1
FROM _timescaledb_catalog.hypertable
WHERE table_name = %s
WHERE table_name = '%s'
) as is_hypertable
`, sanitizeIdentifier(tableName))
`, sanitizeStringLiteral(tableName))

result, err := t.ExecuteSQLWithoutParams(ctx, query)
if err != nil {
Expand Down Expand Up @@ -357,10 +357,10 @@ func (t *DB) RecentChunks(ctx context.Context, tableName string, limit int) (int
range_start,
range_end
FROM timescaledb_information.chunks
WHERE hypertable_name = %s
WHERE hypertable_name = '%s'
ORDER BY range_end DESC
LIMIT %d
`, sanitizeIdentifier(tableName), limit)
`, sanitizeStringLiteral(tableName), limit)

result, err := t.ExecuteSQLWithoutParams(ctx, query)
if err != nil {
Expand Down
Loading