By yanniboi: Allow reordering and configuring of tabs.#82
Open
By yanniboi: Allow reordering and configuring of tabs.#82
Conversation
yanniboi
force-pushed
the
feature/dashboard-sortable-tabs
branch
from
693ac4b to
3e29de2
Compare
yanniboi
force-pushed
the
feature/dashboard-sortable-tabs
branch
from
3e29de2 to
70722b3
Compare
andrewbelcher
requested changes
Mar 19, 2018
Collaborator
andrewbelcher
left a comment
andrewbelcher
left a comment
There was a problem hiding this comment.
I think at some point we'll want to review the AJAX/no JS/routing etc, but that can happen post May. For now let's get something quick in accessibility wise (probably just a title attribute).
| 'data-dialog-type' => 'dialog', | ||
| 'data-dialog-renderer' => 'off_canvas', | ||
| ], | ||
| ], |
Collaborator
There was a problem hiding this comment.
Can we do something basic towards accessibility for these? So at least a title attribute and ideally some visually hidden text? Not sure how that fits into the open_iconic element atm?
Also, you only set data-ajax-url, what about if we don't have JS, do we expect this not to work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key updates: